Summary: | GetMarcISSN should not return empty ISSN | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi <tomascohen> |
Component: | Architecture, internals, and plumbing | Assignee: | Tomás Cohen Arazi <tomascohen> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | ||
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 12554 | ||
Bug Blocks: | |||
Attachments: |
Bug 12674: (regression tests) GetMarcISSN should not return empty ISSN
Bug 12674: GetMarcISSN should not return empty ISSN Bug 12674: (regression tests) GetMarcISSN should not return empty ISSN Bug 12674: GetMarcISSN should not return empty ISSN [PASSED QA] Bug 12674: (regression tests) GetMarcISSN should not return empty ISSN [PASSED QA] Bug 12674: GetMarcISSN should not return empty ISSN |
Description
Tomás Cohen Arazi
2014-07-29 19:07:41 UTC
Created attachment 30304 [details] [review] Bug 12674: (regression tests) GetMarcISSN should not return empty ISSN Proves GetMarcISSN returns empty ISSNs in the results array. To reproduce: - Run $ prove -v t/db_dependent/Biblio.t Created attachment 30305 [details] [review] Bug 12674: GetMarcISSN should not return empty ISSN This patch makes GetMarcISSN test for empty subfield before pushing to the result array. To test: - Run the regression test => FAILS for all MARC flavours - Apply the patch - Run the regression test => SUCCESS: tests pass - Sign off Sponsored-by: Universidad Nacional de Cordoba Created attachment 31284 [details] [review] Bug 12674: (regression tests) GetMarcISSN should not return empty ISSN Proves GetMarcISSN returns empty ISSNs in the results array. To reproduce: - Run $ prove -v t/db_dependent/Biblio.t Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 31285 [details] [review] Bug 12674: GetMarcISSN should not return empty ISSN This patch makes GetMarcISSN test for empty subfield before pushing to the result array. To test: - Run the regression test => FAILS for all MARC flavours - Apply the patch - Run the regression test => SUCCESS: tests pass - Sign off Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 31287 [details] [review] [PASSED QA] Bug 12674: (regression tests) GetMarcISSN should not return empty ISSN Proves GetMarcISSN returns empty ISSNs in the results array. To reproduce: - Run $ prove -v t/db_dependent/Biblio.t Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 31288 [details] [review] [PASSED QA] Bug 12674: GetMarcISSN should not return empty ISSN This patch makes GetMarcISSN test for empty subfield before pushing to the result array. To test: - Run the regression test => FAILS for all MARC flavours - Apply the patch - Run the regression test => SUCCESS: tests pass - Sign off Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Patch pushed to master. |