Bug 12674 - GetMarcISSN should not return empty ISSN
Summary: GetMarcISSN should not return empty ISSN
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Tomás Cohen Arazi
QA Contact: Testopia
URL:
Keywords:
Depends on: 12554
Blocks:
  Show dependency treegraph
 
Reported: 2014-07-29 19:07 UTC by Tomás Cohen Arazi
Modified: 2015-06-04 23:33 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12674: (regression tests) GetMarcISSN should not return empty ISSN (1.55 KB, patch)
2014-07-29 19:16 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 12674: GetMarcISSN should not return empty ISSN (1.00 KB, patch)
2014-07-29 19:16 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 12674: (regression tests) GetMarcISSN should not return empty ISSN (1.62 KB, patch)
2014-08-29 13:57 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 12674: GetMarcISSN should not return empty ISSN (1.07 KB, patch)
2014-08-29 13:57 UTC, Jonathan Druart
Details | Diff | Splinter Review
[PASSED QA] Bug 12674: (regression tests) GetMarcISSN should not return empty ISSN (1.69 KB, patch)
2014-08-29 14:18 UTC, Kyle M Hall
Details | Diff | Splinter Review
[PASSED QA] Bug 12674: GetMarcISSN should not return empty ISSN (1.14 KB, patch)
2014-08-29 14:19 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi 2014-07-29 19:07:41 UTC
Currently, GetMarcISSN returns an array of all present ISSN on a specific record.
Unlike the GetMarcISBN counterpart, it doesn't filter empty ISSNs out.

To reproduce, run the attached regression test.
Comment 1 Tomás Cohen Arazi 2014-07-29 19:16:21 UTC Comment hidden (obsolete)
Comment 2 Tomás Cohen Arazi 2014-07-29 19:16:28 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2014-08-29 13:57:48 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2014-08-29 13:57:54 UTC Comment hidden (obsolete)
Comment 5 Kyle M Hall 2014-08-29 14:18:55 UTC
Created attachment 31287 [details] [review]
[PASSED QA] Bug 12674: (regression tests) GetMarcISSN should not return empty ISSN

Proves GetMarcISSN returns empty ISSNs in the results array.

To reproduce:
 - Run $ prove -v t/db_dependent/Biblio.t

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 6 Kyle M Hall 2014-08-29 14:19:04 UTC
Created attachment 31288 [details] [review]
[PASSED QA] Bug 12674: GetMarcISSN should not return empty ISSN

This patch makes GetMarcISSN test for empty subfield before pushing to the
result array.

To test:
- Run the regression test
=> FAILS for all MARC flavours
- Apply the patch
- Run the regression test
=> SUCCESS: tests pass
- Sign off

Sponsored-by: Universidad Nacional de Cordoba

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 7 Tomás Cohen Arazi 2014-09-01 13:53:06 UTC
Patch pushed to master.