Bug 12698

Summary: If user changes home library in Opac change is not visible in staff client
Product: Koha Reporter: Marc Véron <veron>
Component: Staff interfaceAssignee: Marc Véron <veron>
Status: CLOSED FIXED QA Contact: Marcel de Rooy <m.de.rooy>
Severity: normal    
Priority: P4 CC: gmcharlt, m.de.rooy, tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Screenshot OPAC and staff client
Bug 12698 - If user changes home library in Opac change is not visible in staff client
[SIGNED OFF] Bug 12698 - If user changes home library in Opac change is not visible in staff client
Bug 12698 - If user changes home library in Opac change is not visible in staff client
Bug 12698 - If user changes home library in Opac change is not visible in staff client

Description Marc Véron 2014-08-02 20:16:38 UTC
Created attachment 30496 [details]
Screenshot OPAC and staff client

If a user changes the home library in Opac, the staff client shows a change request without information about the change. The table Field - From - To is empty.

See screenshot attached.
Comment 1 Marc Véron 2014-08-03 19:00:26 UTC Comment hidden (obsolete)
Comment 2 Nick Clemens (kidclamp) 2014-08-07 06:52:08 UTC Comment hidden (obsolete)
Comment 3 Marcel de Rooy 2014-08-07 10:41:21 UTC Comment hidden (obsolete)
Comment 4 Tomás Cohen Arazi 2014-09-08 16:06:42 UTC
Patch pushed to master.

Thanks Marc!
Comment 5 Tomás Cohen Arazi 2014-09-08 16:07:19 UTC
Created attachment 31465 [details] [review]
Bug 12698 - If user changes home library in Opac change is not visible in staff client

To test:
- Set opacuserlogin and OPACPatronDetails to allow
- Log in to OPAC, go to 'your personal details'
- Change Home library
- Go to staff client: Patrons requesting modifications (/cgi-bin/koha/members/members-update.pl)
- Without patch, you do not see the change request, but can Approve, Deny or Ignore it
- With patch, you see the change request, indicating the Home library (branchcode)

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
I "slightly" rewrote the patch so it applies on current master.