Bug 12698 - If user changes home library in Opac change is not visible in staff client
Summary: If user changes home library in Opac change is not visible in staff client
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P4 normal (vote)
Assignee: Marc Véron
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-02 20:16 UTC by Marc Véron
Modified: 2015-06-04 23:33 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Screenshot OPAC and staff client (62.16 KB, image/png)
2014-08-02 20:16 UTC, Marc Véron
Details
Bug 12698 - If user changes home library in Opac change is not visible in staff client (1.31 KB, patch)
2014-08-03 19:00 UTC, Marc Véron
Details | Diff | Splinter Review
[SIGNED OFF] Bug 12698 - If user changes home library in Opac change is not visible in staff client (1.37 KB, patch)
2014-08-07 06:52 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 12698 - If user changes home library in Opac change is not visible in staff client (1.46 KB, patch)
2014-08-07 10:41 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 12698 - If user changes home library in Opac change is not visible in staff client (1.60 KB, patch)
2014-09-08 16:07 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Véron 2014-08-02 20:16:38 UTC
Created attachment 30496 [details]
Screenshot OPAC and staff client

If a user changes the home library in Opac, the staff client shows a change request without information about the change. The table Field - From - To is empty.

See screenshot attached.
Comment 1 Marc Véron 2014-08-03 19:00:26 UTC Comment hidden (obsolete)
Comment 2 Nick Clemens (kidclamp) 2014-08-07 06:52:08 UTC Comment hidden (obsolete)
Comment 3 Marcel de Rooy 2014-08-07 10:41:21 UTC Comment hidden (obsolete)
Comment 4 Tomás Cohen Arazi 2014-09-08 16:06:42 UTC
Patch pushed to master.

Thanks Marc!
Comment 5 Tomás Cohen Arazi 2014-09-08 16:07:19 UTC
Created attachment 31465 [details] [review]
Bug 12698 - If user changes home library in Opac change is not visible in staff client

To test:
- Set opacuserlogin and OPACPatronDetails to allow
- Log in to OPAC, go to 'your personal details'
- Change Home library
- Go to staff client: Patrons requesting modifications (/cgi-bin/koha/members/members-update.pl)
- Without patch, you do not see the change request, but can Approve, Deny or Ignore it
- With patch, you see the change request, indicating the Home library (branchcode)

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
I "slightly" rewrote the patch so it applies on current master.