Bug 12707

Summary: Remove CGI::scrolling_list from some Reports
Product: Koha Reporter: Bernardo Gonzalez Kriegel <bgkriegel>
Component: TemplatesAssignee: Bernardo Gonzalez Kriegel <bgkriegel>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: katrin.fischer, tomascohen, veron
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 12696    
Bug Blocks: 766    
Attachments: Bug 12707: Remove CGI::scrolling_list from some Reports
[Signed-off] Bug 12707: Remove CGI::scrolling_list from some Reports
[PASSED QA] Bug 12707: Remove CGI::scrolling_list from some Reports

Description Bernardo Gonzalez Kriegel 2014-08-03 19:54:45 UTC
Six files, 5 functional, one commented.
Depends on Bug 12696.
Comment 1 Bernardo Gonzalez Kriegel 2014-08-03 20:10:40 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2014-08-05 08:05:21 UTC
Sorry, mistaked in Bug-number. Reset to Needs Signoff
Comment 3 Marc Véron 2014-08-05 08:26:08 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2014-08-15 14:35:17 UTC
Sorry, this one is being stubborn and won't apply:
Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y
Applying: Bug 12707: Remove CGI::scrolling_list from some Reports
fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_out.tt).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 12707: Remove CGI::scrolling_list from some Reports
The copy of the patch that failed is found in:
   /home/katrin/kohaclone/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Comment 5 Katrin Fischer 2014-08-15 14:41:00 UTC
Missed the dependency - going to retry a bit later.
Comment 6 Katrin Fischer 2014-08-15 17:02:10 UTC
Created attachment 30852 [details] [review]
[PASSED QA] Bug 12707: Remove CGI::scrolling_list from some Reports

This patch removes similar instances on 5 files, same code.
Also removes a commented one, changed in case some plan to
resurrect the code.

This bug depends on Bug 12696.

In all cases but the commented one, what was replaced
is a pulldown with one value, 'CSV'

To test:
1. Apply patch for Bug 12696
2. Apply this patch

Check for the pulldown 'Into an application'

3. Go to Reports > Statistics wizard > Borrowers
4. Go to Reports > Statistics wizard > Circulation
5. Go to Reports > Statistics wizard > Holds
6. Go to Reports > Top lists > Most-circulated items
7. Go to Reports > Inactive > Patrons who haven't checked out

8. There is also a commented code on catalogue_stats, no fuctional
changes.

Followed test plan. Patch behaves as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, passes tests and QA script.
Comment 7 Tomás Cohen Arazi 2014-08-15 18:00:36 UTC
Patch pushed to master.

Thanks Bernardo!