Summary: | Add StatisticsFields to sysprefs.sql | ||
---|---|---|---|
Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
Component: | Architecture, internals, and plumbing | Assignee: | Marcel de Rooy <m.de.rooy> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | bgkriegel, katrin.fischer, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 12728: Add StatisticsFields to sysprefs.sql
[SIGNED-OFF] Bug 12728: Add StatisticsFields to sysprefs.sql [PASSED QA] Bug 12728: Add StatisticsFields to sysprefs.sql Bug 12728: [QA Follow-up] Add StatisticsFields to sysprefs.sql |
Description
Marcel de Rooy
2014-08-07 12:16:01 UTC
Created attachment 30578 [details] [review] Bug 12728: Add StatisticsFields to sysprefs.sql Bug 7955: [Statistics tab for Patron checkouts] introduced the pref StatisticsFields but did not add it to the sql install file. Test plan: Run webinstaller or mysql ... < sysprefs.sql Verify that the new pref is in your systempreferences table. Created attachment 30588 [details] [review] [SIGNED-OFF] Bug 12728: Add StatisticsFields to sysprefs.sql Bug 7955: [Statistics tab for Patron checkouts] introduced the pref StatisticsFields but did not add it to the sql install file. Test plan: Run webinstaller or mysql ... < sysprefs.sql Verify that the new pref is in your systempreferences table. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Run webinstall, new syspref loaded. No koha-qa errors. Created attachment 30865 [details] [review] [PASSED QA] Bug 12728: Add StatisticsFields to sysprefs.sql Bug 7955: [Statistics tab for Patron checkouts] introduced the pref StatisticsFields but did not add it to the sql install file. Test plan: Run webinstaller or mysql ... < sysprefs.sql Verify that the new pref is in your systempreferences table. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Run webinstall, new syspref loaded. No koha-qa errors. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> The patch is ok, but should we also add a updatedatabase entry adding it to the installations it's missing from now? Created attachment 31044 [details] [review] Bug 12728: [QA Follow-up] Add StatisticsFields to sysprefs.sql This patch adds a dbrev. If people installed Koha after the initial dbrev (3.09.00.015), an install with sysprefs.sql did not add the pref. So they still could not have it. Test plan: If you have the pref, running an database update should not do anything. If you do not have the pref (delete it via mysql), it should be added. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> (In reply to Katrin Fischer from comment #4) > The patch is ok, but should we also add a updatedatabase entry adding it to > the installations it's missing from now? Added it for completeness. Patches pushed to master. Thanks Marcel! |