Bug 12728 - Add StatisticsFields to sysprefs.sql
Summary: Add StatisticsFields to sysprefs.sql
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Marcel de Rooy
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-07 12:16 UTC by Marcel de Rooy
Modified: 2015-12-03 22:00 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12728: Add StatisticsFields to sysprefs.sql (1.94 KB, patch)
2014-08-07 12:19 UTC, Marcel de Rooy
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 12728: Add StatisticsFields to sysprefs.sql (2.01 KB, patch)
2014-08-07 14:59 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[PASSED QA] Bug 12728: Add StatisticsFields to sysprefs.sql (2.06 KB, patch)
2014-08-15 20:21 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 12728: [QA Follow-up] Add StatisticsFields to sysprefs.sql (1.54 KB, patch)
2014-08-21 11:22 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2014-08-07 12:16:01 UTC
Bug 7955: [Statistics tab for Patron checkouts] introduced pref StatisticsFields but did not add it to the sql install file.
Comment 1 Marcel de Rooy 2014-08-07 12:19:20 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2014-08-07 14:59:08 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-08-15 20:21:25 UTC
Created attachment 30865 [details] [review]
[PASSED QA] Bug 12728: Add StatisticsFields to sysprefs.sql

Bug 7955: [Statistics tab for Patron checkouts] introduced the pref
StatisticsFields but did not add it to the sql install file.

Test plan:
Run webinstaller or mysql ... < sysprefs.sql
Verify that the new pref is in your systempreferences table.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Run webinstall, new syspref loaded.
No koha-qa errors.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Comment 4 Katrin Fischer 2014-08-15 20:22:39 UTC
The patch is ok, but should we also add a updatedatabase entry adding it to the installations it's missing from now?
Comment 5 Marcel de Rooy 2014-08-21 11:22:33 UTC
Created attachment 31044 [details] [review]
Bug 12728: [QA Follow-up] Add StatisticsFields to sysprefs.sql

This patch adds a dbrev.
If people installed Koha after the initial dbrev (3.09.00.015), an install
with sysprefs.sql did not add the pref. So they still could not have it.

Test plan:
If you have the pref, running an database update should not do anything.
If you do not have the pref (delete it via mysql), it should be added.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 6 Marcel de Rooy 2014-08-21 11:22:53 UTC
(In reply to Katrin Fischer from comment #4)
> The patch is ok, but should we also add a updatedatabase entry adding it to
> the installations it's missing from now?

Added it for completeness.
Comment 7 Tomás Cohen Arazi 2014-09-18 00:37:16 UTC
Patches pushed to master.

Thanks Marcel!