Bug 12849

Summary: Sending a list has malformed links
Product: Koha Reporter: Robin Sheat <robin>
Component: OPACAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: major    
Priority: P3 CC: fridolin.somers, gmcharlt, tomascohen
Version: 3.14   
Hardware: All   
OS: All   
See Also: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 12849 - fix URLs in sent lists
[SIGNED OFF] Bug 12849 - fix URLs in sent lists
[PASSED QA] Bug 12849 - fix URLs in sent lists

Description Robin Sheat 2014-08-29 04:18:48 UTC
If you send a list, the links are missing http(s) because the script overrides the OPACBaseURL value sent to the template.
Comment 1 Robin Sheat 2014-08-29 04:21:08 UTC Comment hidden (obsolete)
Comment 2 Nick Clemens (kidclamp) 2014-09-03 02:28:48 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-09-08 19:58:19 UTC
Created attachment 31473 [details] [review]
[PASSED QA] Bug 12849 - fix URLs in sent lists

This brings back the http(s) to the URLs in sent lists.

Test plan:
* make a list
* send it to yourself
* see that the URLs aren't clickable
* apply the patch
* repeat, except now the URLs are better

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
By removing this bit of code, the code in Auth.pm is used
instead. The code there is not perfect, but the solution
works and both list and cart use the same code.

Passes tests and QA script.
Comment 4 Tomás Cohen Arazi 2014-09-09 13:54:20 UTC
Patch pushed to master.

Thanks Robin!
Comment 5 Galen Charlton 2014-10-27 22:49:17 UTC
Pushed to 3.16.x for inclusion in 3.16.5.
Comment 6 Fridolin Somers 2014-12-29 17:35:57 UTC
Pushed to 3.14.x, will be in 3.14.13