Bug 12849 - Sending a list has malformed links
Summary: Sending a list has malformed links
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: 3.14
Hardware: All All
: P3 major
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-29 04:18 UTC by Robin Sheat
Modified: 2016-06-21 21:36 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 12849 - fix URLs in sent lists (983 bytes, patch)
2014-08-29 04:21 UTC, Robin Sheat 		Details | Diff | Splinter Review
[SIGNED OFF] Bug 12849 - fix URLs in sent lists (1.03 KB, patch)
2014-09-03 02:28 UTC, Nick Clemens (kidclamp) 		Details | Diff | Splinter Review
[PASSED QA] Bug 12849 - fix URLs in sent lists (1.27 KB, patch)
2014-09-08 19:58 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Sheat 2014-08-29 04:18:48 UTC 
If you send a list, the links are missing http(s) because the script overrides the OPACBaseURL value sent to the template.
Comment 1 Robin Sheat 2014-08-29 04:21:08 UTC Comment hidden (obsolete)
Comment 2 Nick Clemens (kidclamp) 2014-09-03 02:28:48 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-09-08 19:58:19 UTC 
Created attachment 31473 [details] [review]
[PASSED QA] Bug 12849 - fix URLs in sent lists

This brings back the http(s) to the URLs in sent lists.

Test plan:
* make a list
* send it to yourself
* see that the URLs aren't clickable
* apply the patch
* repeat, except now the URLs are better

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
By removing this bit of code, the code in Auth.pm is used
instead. The code there is not perfect, but the solution
works and both list and cart use the same code.

Passes tests and QA script.
Comment 4 Tomás Cohen Arazi (tcohen) 2014-09-09 13:54:20 UTC 
Patch pushed to master.

Thanks Robin!
Comment 5 Galen Charlton 2014-10-27 22:49:17 UTC 
Pushed to 3.16.x for inclusion in 3.16.5.
Comment 6 Fridolin Somers 2014-12-29 17:35:57 UTC 
Pushed to 3.14.x, will be in 3.14.13