Summary: | 'Clear date' links on start and expiration hold date in staff not working | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | nengard, nick, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 12893 - 'Clear date' links on start and expiration hold date in staff not working
[SIGNED OFF] Bug 12893 - 'Clear date' links on start and expiration hold date in staff not working [PASSED QA] Bug 12893 - 'Clear date' links on start and expiration hold date in staff not working |
Description
Katrin Fischer
2014-09-08 20:53:03 UTC
*** Bug 12947 has been marked as a duplicate of this bug. *** Created attachment 31685 [details] [review] Bug 12893 - 'Clear date' links on start and expiration hold date in staff not working I introduced this bug with my patch for Bug 8181. In changing the way the date picker widgets worked I changed the ID the "clear date" javascript was looking for, so it stopped working. This patch corrects it and improves the JavaScript by moving it out of the HTML markup. This patch also makes some minor HTML validity corrections: escaping ampersands and removing a "size" attribute from a hidden form field. To test, you should have the AllowHoldDateInFuture system preference enabled. Place a hold in the staff client for a patron and confirm that you can choose a "hold starts on" date and a "hold expires on" date and that the respective "clear date" links work correctly for each one. Created attachment 31996 [details] [review] [SIGNED OFF] Bug 12893 - 'Clear date' links on start and expiration hold date in staff not working I introduced this bug with my patch for Bug 8181. In changing the way the date picker widgets worked I changed the ID the "clear date" javascript was looking for, so it stopped working. This patch corrects it and improves the JavaScript by moving it out of the HTML markup. This patch also makes some minor HTML validity corrections: escaping ampersands and removing a "size" attribute from a hidden form field. To test, you should have the AllowHoldDateInFuture system preference enabled. Place a hold in the staff client for a patron and confirm that you can choose a "hold starts on" date and a "hold expires on" date and that the respective "clear date" links work correctly for each one. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Created attachment 32130 [details] [review] [PASSED QA] Bug 12893 - 'Clear date' links on start and expiration hold date in staff not working I introduced this bug with my patch for Bug 8181. In changing the way the date picker widgets worked I changed the ID the "clear date" javascript was looking for, so it stopped working. This patch corrects it and improves the JavaScript by moving it out of the HTML markup. This patch also makes some minor HTML validity corrections: escaping ampersands and removing a "size" attribute from a hidden form field. To test, you should have the AllowHoldDateInFuture system preference enabled. Place a hold in the staff client for a patron and confirm that you can choose a "hold starts on" date and a "hold expires on" date and that the respective "clear date" links work correctly for each one. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Patch pushed to master. Thanks Owen! |