Bug 12893 - 'Clear date' links on start and expiration hold date in staff not working
Summary: 'Clear date' links on start and expiration hold date in staff not working
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
: 12947 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-09-08 20:53 UTC by Katrin Fischer
Modified: 2015-06-04 23:32 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12893 - 'Clear date' links on start and expiration hold date in staff not working (3.59 KB, patch)
2014-09-17 19:00 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED OFF] Bug 12893 - 'Clear date' links on start and expiration hold date in staff not working (3.63 KB, patch)
2014-10-05 01:27 UTC, Nick Clemens
Details | Diff | Splinter Review
[PASSED QA] Bug 12893 - 'Clear date' links on start and expiration hold date in staff not working (3.67 KB, patch)
2014-10-10 12:44 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2014-09-08 20:53:03 UTC
To reproduce:
- activate future holds for the staff side
- place a hold
- add dates for start and expiration date
- try to clear the dates using the links
- notice Javascript error
Comment 1 Owen Leonard 2014-09-17 18:14:34 UTC
*** Bug 12947 has been marked as a duplicate of this bug. ***
Comment 2 Owen Leonard 2014-09-17 19:00:51 UTC Comment hidden (obsolete)
Comment 3 Nick Clemens 2014-10-05 01:27:30 UTC Comment hidden (obsolete)
Comment 4 Kyle M Hall 2014-10-10 12:44:28 UTC
Created attachment 32130 [details] [review]
[PASSED QA] Bug 12893 - 'Clear date' links on start and expiration hold date in staff not working

I introduced this bug with my patch for Bug 8181. In changing the way
the date picker widgets worked I changed the ID the "clear date"
javascript was looking for, so it stopped working.

This patch corrects it and improves the JavaScript by moving it out of
the HTML markup.

This patch also makes some minor HTML validity corrections: escaping
ampersands and removing a "size" attribute from a hidden form field.

To test, you should have the AllowHoldDateInFuture system preference
enabled. Place a hold in the staff client for a patron and confirm that
you can choose a "hold starts on" date and a "hold expires on" date and
that the respective "clear date" links work correctly for each one.

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 5 Tomás Cohen Arazi 2014-11-21 19:03:29 UTC
Patch pushed to master.

Thanks Owen!