Bug 14308

Summary: Remove CGI::checkbox from subfield editors
Product: Koha Reporter: Bernardo Gonzalez Kriegel <bgkriegel>
Component: TemplatesAssignee: Bernardo Gonzalez Kriegel <bgkriegel>
Status: RESOLVED DUPLICATE QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: indradg, jonathan.druart, m.de.rooy
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15773
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: proposed patch

Description Bernardo Gonzalez Kriegel 2015-06-01 12:27:46 UTC
Use of CGI::checkbox prevents customization of templates
Comment 1 Bernardo Gonzalez Kriegel 2015-06-01 12:53:54 UTC
Created attachment 39739 [details] [review]
proposed patch

Bug 14308: Remove CGI::checkbox from subfield editors

This patch removes use of CGI::checkbox from
frameworks subfield editors.
Also removes use of CGI::escapeHTML

To test:
1) Apply the patch
2) Go to bibliographic frameworks, edit a field with subfields
3) Check for regressions on Edit/Save/Add subfields
i.e.
a. Edit subfield with known values on repeatable, mandatory, isurl checkbox
b. Change values, save, edit again and verify values.

4) Go to authority frameworks, edit a field with subfields
5) Check for regressions on Edit/Save/Add subfields
Comment 2 Marcel de Rooy 2015-08-27 12:20:18 UTC
Bernardo,
There is some problem in the authority side of this.
I cannot add a new subfield. I saw that existing data was overwritten.
Comment 3 Jonathan Druart 2016-02-18 11:32:38 UTC
Too bad that I have not seen your patch before, I have done the same job on bug 15773 :-/
Comment 4 Owen Leonard 2016-08-09 12:46:28 UTC

*** This bug has been marked as a duplicate of bug 15773 ***