Bug 14624

Summary: <<items.content>> for advance_notices.pl wrongly documented
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: Command-line UtilitiesAssignee: natasha <tasham_8>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: brendan, chris, f.demians, jonathan.druart, julian.maurice, mtompset, robin
Version: MainKeywords: Academy
Hardware: All   
OS: All   
See Also: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9499
Change sponsored?: --- Patch complexity: String patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 14624 - <<items.content>> for advance_notices.pl wrongly documented To Test Check perldoc for misc/cronjobs/advance_noitces.pl and see that the documentation matches.
Bug 14624 - <<items.content>> for advance_notices.pl wrongly documented To Test Check perldoc for misc/cronjobs/advance_noitces.pl and see that the documentation matches.
Bug 14624 - <<items.content>> for advance_notices.pl wrongly documented
Bug 14624 - <<items.content>> for advance_notices.pl wrongly documented

Description Katrin Fischer 2015-07-31 07:57:28 UTC
Dokumentation states:
143 =item E<lt>E<lt>items.contentE<gt>E<gt>
144
145 one line for each item, each line containing a tab separated list of
146 title, author, barcode, issuedate

Code states:
170 my $itemscontent = join(',',qw( date_due title author barcode ));

They don't match!
Comment 1 Katrin Fischer 2016-01-17 23:59:40 UTC
The documentation of the script and how it works don't match up - we should fix the documentation.
Comment 2 natasha 2016-01-19 03:04:22 UTC Comment hidden (obsolete)
Comment 3 Mark Tompsett 2016-01-20 23:44:54 UTC
Bug 9499 failed to document it correctly in both places. Line 104 was correct, but line 147 is not. This patch visually fixes that.
Comment 4 Mark Tompsett 2016-01-20 23:50:43 UTC Comment hidden (obsolete)
Comment 5 Katrin Fischer 2016-01-22 11:22:01 UTC Comment hidden (obsolete)
Comment 6 Katrin Fischer 2016-01-22 11:24:43 UTC
Created attachment 47174 [details] [review]
Bug 14624 - <<items.content>> for advance_notices.pl wrongly documented

To Test Check perldoc for misc/cronjobs/advance_noitces.pl
and see that the documentation matches.

Ran:
$ perldoc misc/cronjobs/advance_noitces.pl
Saw expected changes.
Koha QA test tools pass too.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Switched due date for the name of the database column
date_due as the parameter expects a list of database
column names.
Comment 7 Brendan Gallagher 2016-01-27 04:34:06 UTC
Pushed to Master - Should be in the may 2016 release. Thanks!
Comment 8 Julian Maurice 2016-01-29 14:19:07 UTC
Patch pushed to 3.22.x, will be in 3.22.3
Comment 9 Frédéric Demians 2016-02-12 06:40:51 UTC
This patch has been pushed to 3.20.x, will be in 3.20.9.