Bug 14624 - <<items.content>> for advance_notices.pl wrongly documented
Summary: <<items.content>> for advance_notices.pl wrongly documented
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Command-line Utilities (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: natasha
QA Contact: Testopia
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2015-07-31 07:57 UTC by Katrin Fischer
Modified: 2017-01-10 19:34 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 14624 - <<items.content>> for advance_notices.pl wrongly documented To Test Check perldoc for misc/cronjobs/advance_noitces.pl and see that the documentation matches. (885 bytes, patch)
2016-01-19 03:04 UTC, natasha 		Details | Diff | Splinter Review
Bug 14624 - <<items.content>> for advance_notices.pl wrongly documented To Test Check perldoc for misc/cronjobs/advance_noitces.pl and see that the documentation matches. (1.01 KB, patch)
2016-01-20 23:50 UTC, Mark Tompsett 		Details | Diff | Splinter Review
Bug 14624 - <<items.content>> for advance_notices.pl wrongly documented (1.18 KB, patch)
2016-01-22 11:22 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Bug 14624 - <<items.content>> for advance_notices.pl wrongly documented (1.53 KB, patch)
2016-01-22 11:24 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2015-07-31 07:57:28 UTC 
Dokumentation states:
143 =item E<lt>E<lt>items.contentE<gt>E<gt>
144
145 one line for each item, each line containing a tab separated list of
146 title, author, barcode, issuedate

Code states:
170 my $itemscontent = join(',',qw( date_due title author barcode ));

They don't match!
Comment 1 Katrin Fischer 2016-01-17 23:59:40 UTC 
The documentation of the script and how it works don't match up - we should fix the documentation.
Comment 2 natasha 2016-01-19 03:04:22 UTC Comment hidden (obsolete)
Comment 3 Mark Tompsett 2016-01-20 23:44:54 UTC 
Bug 9499 failed to document it correctly in both places. Line 104 was correct, but line 147 is not. This patch visually fixes that.
Comment 4 Mark Tompsett 2016-01-20 23:50:43 UTC Comment hidden (obsolete)
Comment 5 Katrin Fischer 2016-01-22 11:22:01 UTC Comment hidden (obsolete)
Comment 6 Katrin Fischer 2016-01-22 11:24:43 UTC 
Created attachment 47174 [details] [review]
Bug 14624 - <<items.content>> for advance_notices.pl wrongly documented

To Test Check perldoc for misc/cronjobs/advance_noitces.pl
and see that the documentation matches.

Ran:
$ perldoc misc/cronjobs/advance_noitces.pl
Saw expected changes.
Koha QA test tools pass too.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Switched due date for the name of the database column
date_due as the parameter expects a list of database
column names.
Comment 7 Brendan Gallagher 2016-01-27 04:34:06 UTC 
Pushed to Master - Should be in the may 2016 release. Thanks!
Comment 8 Julian Maurice 2016-01-29 14:19:07 UTC 
Patch pushed to 3.22.x, will be in 3.22.3
Comment 9 Frédéric Demians 2016-02-12 06:40:51 UTC 
This patch has been pushed to 3.20.x, will be in 3.20.9.