Summary: | Allow C4::Context->interface to be set to 'sip' or 'commandline' | ||
---|---|---|---|
Product: | Koha | Reporter: | Kyle M Hall <kyle.m.hall> |
Component: | Architecture, internals, and plumbing | Assignee: | Kyle M Hall <kyle.m.hall> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | brendan, jonathan.druart, m.de.rooy |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 14751 - Allow C4::Context->interface to be set to 'sip' or 'commandline'
Bug 14751 - Allow C4::Context->interface to be set to 'sip' or 'commandline' Bug 14751 - Allow C4::Context->interface to be set to 'sip' or 'commandline' Bug 14751: [QA Follow-up] Unit tests for interface method |
Description
Kyle M Hall
2015-08-28 11:30:28 UTC
Created attachment 42061 [details] [review] Bug 14751 - Allow C4::Context->interface to be set to 'sip' or 'commandline' Koha::Logger allows us to split up logging to separate files based on the interface. However, right now the interface is limited to just 'opac' or 'intranet'. We should extend this to allow the interface to also be set to 'sip' for SIP server logging, and to 'commandline' for cronjobs and all other command line scripts. Created attachment 46181 [details] [review] Bug 14751 - Allow C4::Context->interface to be set to 'sip' or 'commandline' Koha::Logger allows us to split up logging to separate files based on the interface. However, right now the interface is limited to just 'opac' or 'intranet'. We should extend this to allow the interface to also be set to 'sip' for SIP server logging, and to 'commandline' for cronjobs and all other command line scripts. Signed-off-by: Chris <chris@bigballofwax.co.nz> Does what it says on the tin I don't find where interface is set to "sip" or "commandline". Can we get a test plan please? Created attachment 47679 [details] [review] Bug 14751 - Allow C4::Context->interface to be set to 'sip' or 'commandline' Koha::Logger allows us to split up logging to separate files based on the interface. However, right now the interface is limited to just 'opac' or 'intranet'. We should extend this to allow the interface to also be set to 'sip' for SIP server logging, and to 'commandline' for cronjobs and all other command line scripts. Signed-off-by: Chris <chris@bigballofwax.co.nz> Does what it says on the tin Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 47680 [details] [review] Bug 14751: [QA Follow-up] Unit tests for interface method Added some descriptions in Context.t and added two tests for sip and commandline. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to Master - Should be in the May 2016 Release. Thanks |