Bug 14751 - Allow C4::Context->interface to be set to 'sip' or 'commandline'
Summary: Allow C4::Context->interface to be set to 'sip' or 'commandline'
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Kyle M Hall
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-28 11:30 UTC by Kyle M Hall
Modified: 2017-06-14 22:02 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 14751 - Allow C4::Context->interface to be set to 'sip' or 'commandline' (1.16 KB, patch)
2015-08-28 11:32 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 14751 - Allow C4::Context->interface to be set to 'sip' or 'commandline' (1.24 KB, patch)
2016-01-04 03:37 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 14751 - Allow C4::Context->interface to be set to 'sip' or 'commandline' (1.33 KB, patch)
2016-02-05 08:45 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 14751: [QA Follow-up] Unit tests for interface method (2.21 KB, patch)
2016-02-05 08:45 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2015-08-28 11:30:28 UTC
Koha::Logger allows us to split up logging to separate files based on the interface. However, right now the interface is limited to just 'opac' or 'intranet'.

I propose we extend this to allow the interface to also be set to 'sip' for SIP server logging, and to 'commandline' for cronjobs and all other command line scripts.
Comment 1 Kyle M Hall 2015-08-28 11:32:03 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2016-01-04 03:37:25 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-01-04 13:01:04 UTC
I don't find where interface is set to "sip" or "commandline".
Can we get a test plan please?
Comment 4 Marcel de Rooy 2016-02-05 08:45:08 UTC
Created attachment 47679 [details] [review]
Bug 14751 - Allow C4::Context->interface to be set to 'sip' or 'commandline'

Koha::Logger allows us to split up logging to separate files based on
the interface. However, right now the interface is limited to just
'opac' or 'intranet'.

We should extend this to allow the interface to also be set to 'sip'
for SIP server logging, and to 'commandline' for cronjobs and all other
command line scripts.

Signed-off-by: Chris <chris@bigballofwax.co.nz>

Does what it says on the tin

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 5 Marcel de Rooy 2016-02-05 08:45:12 UTC
Created attachment 47680 [details] [review]
Bug 14751: [QA Follow-up] Unit tests for interface method

Added some descriptions in Context.t and added two tests for sip
and commandline.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 6 Brendan Gallagher 2016-03-02 04:23:03 UTC
Pushed to Master - Should be in the May 2016 Release.  Thanks