Summary: | acqui/currency.pl is unused | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | |||
Bug Blocks: | 15084 | ||
Attachments: |
Bug 15083: Remove acqui/currency.pl
[SIGNED-OFF] Bug 15083: Remove acqui/currency.pl [PASSED QA] Bug 15083: Remove acqui/currency.pl |
Description
Jonathan Druart
2015-10-29 14:43:12 UTC
Created attachment 44155 [details] [review] Bug 15083: Remove acqui/currency.pl This script has scary FIXMEs and can be removed. It is never called from Koha code. On the way, this patch remove the C4::Budgets::ModCurrencies subroutine, which was only called from this script. Test plan: git grep 'acqui/currency.pl and git grep ModCurrencies should not return anything. Created attachment 44158 [details] [review] [SIGNED-OFF] Bug 15083: Remove acqui/currency.pl This script has scary FIXMEs and can be removed. It is never called from Koha code. On the way, this patch remove the C4::Budgets::ModCurrencies subroutine, which was only called from this script. Test plan: git grep 'acqui/currency.pl and git grep ModCurrencies should not return anything. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No more ModeCurrencies, no call to acqui/currency.pl No errors Created attachment 44458 [details] [review] [PASSED QA] Bug 15083: Remove acqui/currency.pl This script has scary FIXMEs and can be removed. It is never called from Koha code. On the way, this patch remove the C4::Budgets::ModCurrencies subroutine, which was only called from this script. Test plan: git grep 'acqui/currency.pl and git grep ModCurrencies should not return anything. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No more ModeCurrencies, no call to acqui/currency.pl No errors Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Patch pushed to master. Thanks Jonathan! |