Bug 15166

Summary: Make output_pref accept a string as parameter
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: tomascohen, veron
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 12072, 14946, 14969, 14985    
Attachments: Bug 15166: Make output_pref takes a string in parameter
Bug 15166: Make output_pref takes a string in parameter
Bug 15166: Carp if an invalid date is passed
Bug 15166: Carp if an invalid date is passed
[PASSED QA] Bug 15166: Make output_pref takes a string in parameter
[PASSED QA] Bug 15166: Carp if an invalid date is passed

Description Jonathan Druart 2015-11-10 17:46:03 UTC
To simplify the management of dates, it would be great that output_pref takes a string in parameter.

  my $date = $input->param('my_date');
  $date = eval { dt_from_string( $date ) } if $date;
  $date = output_pref({dt => $date}) if $date;

Could be replace with:

  my $date = output_pref({ str => $input->param('my_date') });
Comment 1 Jonathan Druart 2015-11-10 17:47:20 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2015-11-10 21:49:03 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2015-11-11 11:55:51 UTC Comment hidden (obsolete)
Comment 4 Marc Véron 2015-11-11 12:36:38 UTC Comment hidden (obsolete)
Comment 5 Katrin Fischer 2015-11-11 22:08:05 UTC
Created attachment 44779 [details] [review]
[PASSED QA] Bug 15166: Make output_pref takes a string in parameter

To simplify the management of dates, it would be great that output_pref takes a string in parameter.

  my $date = $input->param('my_date');
  $date = eval { dt_from_string( $date ) } if $date;
  $date = output_pref({dt => $date}) if $date;

Could be replace with:

  my $date = output_pref({ str => $input->param('my_date') });

Tested with t/DateUtils.t, passed OK.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Katrin Fischer 2015-11-11 22:08:22 UTC
Created attachment 44780 [details] [review]
[PASSED QA] Bug 15166: Carp if an invalid date is passed

Sign-off on second patch.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Tomás Cohen Arazi 2015-11-13 14:33:30 UTC
Patch pushed to master.

Thanks Jonathan!