This patch removes C4::Dates from following files in folder C4: - C4/Members.pm - C4/Reserves.pm - C4/Search.pm - C4/Utils/DataTables.pm - C4/Utils/DataTables/Members.pm - C4/VirtualShelves/Page.pm
Created attachment 43285 [details] [review] Remove C4::Dates from files in folder C4/*.pm (part one) This patch removes C4::Dates from following files in folder C4: - C4/Members.pm - C4/Reserves.pm - C4/Search.pm - C4/Utils/DataTables.pm - C4/Utils/DataTables/Members.pm - C4/VirtualShelves/Page.pm To test: -run tests as appropriate, - have a close look at the code changes - try to find regressions
Still applies
Hmm, signed-off but no signed-off patch attached?
Marc - my fault - got distracted half way through the sign-off - I will send a patch up in a minute
Created attachment 44439 [details] [review] Remove C4::Dates from files in folder C4/*.pm (part one) This patch removes C4::Dates from following files in folder C4: - C4/Members.pm - C4/Reserves.pm - C4/Search.pm - C4/Utils/DataTables.pm - C4/Utils/DataTables/Members.pm - C4/VirtualShelves/Page.pm To test: -run tests as appropriate, - have a close look at the code changes - try to find regressions http://bugs.koha-community.org/show_bug.cgi?id=14985 Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Marc, we are using eval compulsively. It should only be used for user inputs, not when the data comes from the DB.
(In reply to Jonathan Druart from comment #7) > Marc, we are using eval compulsively. > It should only be used for user inputs, not when the data comes from the DB. Jonathan, maybe I was to anxious / wanted to be on the "save side". Does it harm functionality and/or does it slow down to much everything?
(In reply to Marc Véron from comment #8) > (In reply to Jonathan Druart from comment #7) > > Marc, we are using eval compulsively. > > It should only be used for user inputs, not when the data comes from the DB. > > Jonathan, maybe I was to anxious / wanted to be on the "save side". > Does it harm functionality and/or does it slow down to much everything? It could hide future bugs
Created attachment 44556 [details] [review] Bug 14985: (followup) Remove eval if dates come from database This patch removes some evals from date-formatting where the dates come from the database. See comments #7 - #9 Additionaly, C4/VirtualShelves/Page.pm is removed from the patches (obsolete).
Created attachment 44621 [details] [review] Bug 14985: (followup) Remove C4::Dates from C4/Overdues.pm Ths patch removes a stray C4::Dates from C4/Overdues.pm - To test got to a patron who has overdues (Home > Circulation > Checkouts > [Patron]) - Print overdues
Created attachment 44699 [details] [review] Remove C4::Dates from files in folder C4/*.pm (part one) This patch removes C4::Dates from following files in folder C4: - C4/Members.pm - C4/Reserves.pm - C4/Search.pm - C4/Utils/DataTables.pm - C4/Utils/DataTables/Members.pm - C4/VirtualShelves/Page.pm To test: -run tests as appropriate, - have a close look at the code changes - try to find regressions http://bugs.koha-community.org/show_bug.cgi?id=14985 Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Created attachment 44700 [details] [review] Bug 14985: (followup) Remove eval if dates come from database This patch removes some evals from date-formatting where the dates come from the database. See comments #7 - #9 Additionaly, C4/VirtualShelves/Page.pm is removed from the patches (obsolete).
Created attachment 44701 [details] [review] Bug 14985: (followup) Remove C4::Dates from C4/Overdues.pm Ths patch removes a stray C4::Dates from C4/Overdues.pm - To test got to a patron who has overdues (Home > Circulation > Checkouts > [Patron]) - Print overdues
Created attachment 44739 [details] [review] Bug 14985: Remove C4::Dates from files in folder C4/*.pm (part one) This patch removes C4::Dates from following files in folder C4: - C4/Members.pm - C4/Reserves.pm - C4/Search.pm - C4/Utils/DataTables.pm - C4/Utils/DataTables/Members.pm - C4/VirtualShelves/Page.pm To test: -run tests as appropriate, - have a close look at the code changes - try to find regressions http://bugs.koha-community.org/show_bug.cgi?id=14985 Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Bug 14985: (followup) Remove eval if dates come from database This patch removes some evals from date-formatting where the dates come from the database. See comments #7 - #9 Additionaly, C4/VirtualShelves/Page.pm is removed from the patches (obsolete). Bug 14985: (followup) Remove C4::Dates from C4/Overdues.pm Ths patch removes a stray C4::Dates from C4/Overdues.pm - To test got to a patron who has overdues (Home > Circulation > Checkouts > [Patron]) - Print overdues Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 44740 [details] [review] Bug 14985: Fix regression on patron search This patch fixes 2 major errors introduced by last patch: 1/ Undefined subroutine &C4::Utils::DataTables::Members::dt_from_string called when searching for patrons 2/ Display the dates on the patron search in the pref format, not iso Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 44741 [details] [review] Bug 14985: Simplify the date management in AddReserve The code is much more readable using the str param of output_pref Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Marc, I have squashed your 3 patches to make the log more readable. There were too many changes for the same lines.
Please, check this patchset breaks: $ prove t/db_dependent/Holds.t
Created attachment 44764 [details] [review] zsh:1: command not found: q Bug 14985: dbms expects a iso formatted date
I missed this one!
Created attachment 44765 [details] [review] Bug 14985: dbms expects a iso formatted date
It fails now, on a different way but it fails.
Test passes OK with patch applied on top of Bug 15166
Patches pushed to master. Thanks Marc and Jonathan!