Bug 15298

Summary: z39.50 admin setup, options column suggested changes
Product: Koha Reporter: HB-NEKLS <gwilliams>
Component: Z39.50 / SRU / OpenSearch ServersAssignee: Galen Charlton <gmcharlt>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: trivial    
Priority: P5 - low CC: brendan, chris, f.demians, julian.maurice, katrin.fischer, m.de.rooy
Version: 3.18Keywords: Academy
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15875
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 15298 - z39.50 admin setup, options column suggested changes
[SIGNED-OFF] Bug 15298 - z39.50 admin setup, options column suggested changes
Bug 15298 - z39.50 admin setup, options column suggested changes
Bug 15298 [QA Followup] - Fix whitespace issues

Description HB-NEKLS 2015-12-03 17:56:25 UTC
On the z39.50 server admin page (cgi-bin/koha/admin/z3950servers.pl), the options column has three links lumped together for edit, copy, delete. Could those options be restyled to match the actions menu on the saved reports page? cgi-bin/koha/reports/guided_reports.pl?phase=Use%20saved
Comment 1 Chloe Alabaster 2016-01-19 01:43:16 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2016-01-19 15:31:57 UTC Comment hidden (obsolete)
Comment 3 Owen Leonard 2016-01-19 15:39:05 UTC
Some good possible follow-ups (or new bugs I guess):

1. Validate the HTML to identify some issues with duplicate IDs in the markup. I signed off on the patch because the page already had some duplicate IDs, so it didn't seem fair to hold it up for that. But we should make the page validate.

2. Eliminate the use of 'href="javascript:void(0);"'

Progressive-enhancement best practices say that ideally a real URL should be used instead, one which is a fallback for non-JavaScript users. However, we don't require that the staff client be fully functional without JS turned on, so the accepted alternative is to use 'href="#"' The ConfirmDelete() function already returns false, so clicking the link won't result in the page jumping around.
Comment 4 Kyle M Hall 2016-01-19 19:29:28 UTC
Created attachment 46922 [details] [review]
Bug 15298 - z39.50 admin setup, options column suggested changes

To Test-
1-first look at the orginal Z39.50/SRU servers administration page
  (/cgi-bin/koha/admin/z3950servers.pl?op=delete_confirmed&id=6)
2-apply patch
3-now see the new styling of the "action" drop down tab like the one on
  the saved reports page
4-check that each link works (for delete i reccommend copying one then
  deleting the copy)

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 5 Kyle M Hall 2016-01-19 19:29:35 UTC
Created attachment 46923 [details] [review]
Bug 15298 [QA Followup] - Fix whitespace issues

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 6 Brendan Gallagher 2016-01-27 05:27:24 UTC
Pushed to Master - Should be in the May 2016 release. Thanks!
Comment 7 Julian Maurice 2016-01-29 15:21:59 UTC
Patches pushed to 3.22.x, will be in 3.22.3
Comment 8 Frédéric Demians 2016-02-12 06:46:29 UTC
This patch has been pushed to 3.20.x, will be in 3.20.9.