On the z39.50 server admin page (cgi-bin/koha/admin/z3950servers.pl), the options column has three links lumped together for edit, copy, delete. Could those options be restyled to match the actions menu on the saved reports page? cgi-bin/koha/reports/guided_reports.pl?phase=Use%20saved
Created attachment 46841 [details] [review] Bug 15298 - z39.50 admin setup, options column suggested changes To Test- 1-first look at the orginal Z39.50/SRU servers administration page (/cgi-bin/koha/admin/z3950servers.pl?op=delete_confirmed&id=6) 2-apply patch 3-now see the new styling of the "action" drop down tab like the one on the saved reports page 4-check that each link works (for delete i reccommend copying one then deleting the copy)
Created attachment 46901 [details] [review] [SIGNED-OFF] Bug 15298 - z39.50 admin setup, options column suggested changes To Test- 1-first look at the orginal Z39.50/SRU servers administration page (/cgi-bin/koha/admin/z3950servers.pl?op=delete_confirmed&id=6) 2-apply patch 3-now see the new styling of the "action" drop down tab like the one on the saved reports page 4-check that each link works (for delete i reccommend copying one then deleting the copy) Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Some good possible follow-ups (or new bugs I guess): 1. Validate the HTML to identify some issues with duplicate IDs in the markup. I signed off on the patch because the page already had some duplicate IDs, so it didn't seem fair to hold it up for that. But we should make the page validate. 2. Eliminate the use of 'href="javascript:void(0);"' Progressive-enhancement best practices say that ideally a real URL should be used instead, one which is a fallback for non-JavaScript users. However, we don't require that the staff client be fully functional without JS turned on, so the accepted alternative is to use 'href="#"' The ConfirmDelete() function already returns false, so clicking the link won't result in the page jumping around.
Created attachment 46922 [details] [review] Bug 15298 - z39.50 admin setup, options column suggested changes To Test- 1-first look at the orginal Z39.50/SRU servers administration page (/cgi-bin/koha/admin/z3950servers.pl?op=delete_confirmed&id=6) 2-apply patch 3-now see the new styling of the "action" drop down tab like the one on the saved reports page 4-check that each link works (for delete i reccommend copying one then deleting the copy) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 46923 [details] [review] Bug 15298 [QA Followup] - Fix whitespace issues Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to Master - Should be in the May 2016 release. Thanks!
Patches pushed to 3.22.x, will be in 3.22.3
This patch has been pushed to 3.20.x, will be in 3.20.9.