Description
Marc Véron
2015-12-13 10:56:33 UTC
Created attachment 45616 [details] [review] Bug 15363 - Translatability: Fix issue with ambiguous 'all' on Administration > Set library checkin and transfer policy In branch_transfer_limits.tt, set ambiguous word 'all' (separated by tags) into a translatable context. To test: Apply patch - Go to Home > Administration > Set library checkin and transfer policy - Verify that the word 'all' is no longer separated by tags in "For all collection codes: " rsp. "For all item types: " (Switch with syspref 'BranchTransfersLimitsType') Created attachment 45671 [details] [review] [SIGNED-OFF]Bug 15363: Translatability: Fix issue with ambiguous 'all' on Administration > Set library checkin and transfer policy In branch_transfer_limits.tt, set ambiguous word 'all' (separated by tags) into a translatable context. To test: Apply patch - Go to Home > Administration > Set library checkin and transfer policy - Verify that the word 'all' is no longer separated by tags in "For all collection codes: " rsp. "For all item types: " (Switch with syspref 'BranchTransfersLimitsType') Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works well for translation purpose With this patch, we get msgid "%sFor all collection codes: %sFor all item types: %s" Dont you think it's better to have 2 different entries? You just need to move the strong tag into the IF statement. (In reply to Jonathan Druart from comment #3) > With this patch, we get > msgid "%sFor all collection codes: %sFor all item types: %s" > Dont you think it's better to have 2 different entries? > > You just need to move the strong tag into the IF statement. Hi Jonathan, do you mean the following? <fieldset>[% IF ( limitType == 'ccode' ) %]For <strong>all</strong> collection codes: [% ELSE %]For <strong>all</strong> item types: [% END %]<a id="CheckAll" href="#">Check all</a> | <a id="UncheckAll" href="#">Uncheck all</a></fieldset> If yes, we have the string splitting again, no? No, I meant: [% IF %]<strong>itemtypes</strong>[% ELSE %]<strong>ccode</strong[% END %] Created attachment 45819 [details] [review] Bug 15363: (followup) Move tags inside if statements Followup for comment #3 Created attachment 45827 [details] [review] Bug 15363: Translatability: Fix issue with ambiguous 'all' on Administration > Set library checkin and transfer policy In branch_transfer_limits.tt, set ambiguous word 'all' (separated by tags) into a translatable context. To test: Apply patch - Go to Home > Administration > Set library checkin and transfer policy - Verify that the word 'all' is no longer separated by tags in "For all collection codes: " rsp. "For all item types: " (Switch with syspref 'BranchTransfersLimitsType') Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works well for translation purpose Bug 15363: (followup) Move tags inside if statements Followup for comment #3 Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 46032 [details] [review] Bug 15363: Translatability: Fix issue with ambiguous 'all' on Administration > Set library checkin and transfer policy In branch_transfer_limits.tt, set ambiguous word 'all' (separated by tags) into a translatable context. To test: Apply patch - Go to Home > Administration > Set library checkin and transfer policy - Verify that the word 'all' is no longer separated by tags in "For all collection codes: " rsp. "For all item types: " (Switch with syspref 'BranchTransfersLimitsType') Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works well for translation purpose Bug 15363: (followup) Move tags inside if statements Followup for comment #3 Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Pushed to master - thanks! Patch pushed in 3.22.x, will be in 3.22.2 This patch has been pushed to 3.20.x, will be in 3.20.8. |