Bug 15363 - Translatability: Fix issue with ambiguous 'all' on Administration > Set library checkin and transfer policy
Summary: Translatability: Fix issue with ambiguous 'all' on Administration > Set libra...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Marc Véron
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-13 10:56 UTC by Marc Véron
Modified: 2017-06-14 22:10 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15363 - Translatability: Fix issue with ambiguous 'all' on Administration > Set library checkin and transfer policy (1.90 KB, patch)
2015-12-13 11:06 UTC, Marc Véron
Details | Diff | Splinter Review
[SIGNED-OFF]Bug 15363: Translatability: Fix issue with ambiguous 'all' on Administration > Set library checkin and transfer policy (1.83 KB, patch)
2015-12-14 16:13 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
Bug 15363: (followup) Move tags inside if statements (1.35 KB, patch)
2015-12-18 12:50 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 15363: Translatability: Fix issue with ambiguous 'all' on Administration > Set library checkin and transfer policy (1.98 KB, patch)
2015-12-18 14:09 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 15363: Translatability: Fix issue with ambiguous 'all' on Administration > Set library checkin and transfer policy (2.05 KB, patch)
2015-12-29 20:36 UTC, Brendan Gallagher
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Véron 2015-12-13 10:56:33 UTC
In branch_transfer_limits.tt, set ambiguous word 'all' (separated by tags) into a translatable context.
(Errors occur e.g. in French: "Pour Tous codes de collection:" ).
Comment 1 Marc Véron 2015-12-13 11:06:02 UTC Comment hidden (obsolete)
Comment 2 Héctor Eduardo Castro Avalos 2015-12-14 16:13:15 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2015-12-18 10:15:39 UTC
With this patch, we get
  msgid "%sFor all collection codes: %sFor all item types: %s"
Dont you think it's better to have 2 different entries?

You just need to move the strong tag into the IF statement.
Comment 4 Marc Véron 2015-12-18 11:13:40 UTC
(In reply to Jonathan Druart from comment #3)
> With this patch, we get
>   msgid "%sFor all collection codes: %sFor all item types: %s"
> Dont you think it's better to have 2 different entries?
> 
> You just need to move the strong tag into the IF statement.

Hi Jonathan, do you mean the following?

<fieldset>[% IF ( limitType == 'ccode' ) %]For <strong>all</strong> collection codes: [% ELSE %]For <strong>all</strong> item types: [% END %]<a id="CheckAll" href="#">Check all</a> | <a id="UncheckAll" href="#">Uncheck all</a></fieldset>

If yes, we have the string splitting again, no?
Comment 5 Jonathan Druart 2015-12-18 11:28:06 UTC
No, I meant:
[% IF %]<strong>itemtypes</strong>[% ELSE %]<strong>ccode</strong[% END %]
Comment 6 Marc Véron 2015-12-18 12:50:34 UTC Comment hidden (obsolete)
Comment 7 Jonathan Druart 2015-12-18 14:09:31 UTC Comment hidden (obsolete)
Comment 8 Brendan Gallagher 2015-12-29 20:36:27 UTC
Created attachment 46032 [details] [review]
Bug 15363: Translatability: Fix issue with ambiguous 'all' on Administration > Set library checkin and transfer policy

In branch_transfer_limits.tt, set ambiguous word 'all' (separated by tags) into a
translatable context.

To test:
Apply patch
- Go to Home > Administration > Set library checkin and transfer policy
- Verify that the word 'all' is no longer separated by tags
  in "For all collection codes: " rsp. "For all item types: "
  (Switch with syspref 'BranchTransfersLimitsType')

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works well for translation purpose

Bug 15363: (followup) Move tags inside if statements

Followup for comment #3

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
Comment 9 Brendan Gallagher 2015-12-29 20:36:46 UTC
Pushed to master - thanks!
Comment 10 Julian Maurice 2015-12-30 16:05:20 UTC
Patch pushed in 3.22.x, will be in 3.22.2
Comment 11 Frédéric Demians 2015-12-31 18:24:19 UTC
This patch has been pushed to 3.20.x, will be in 3.20.8.