Bug 15432

Summary: t/db_dependent/Letters.t depends on external data/configuration
Product: Koha Reporter: Marc Véron <veron>
Component: Architecture, internals, and plumbingAssignee: Marc Véron <veron>
Status: CLOSED FIXED QA Contact: Marc Véron <veron>
Severity: minor    
Priority: P5 - low CC: f.demians, jonathan.druart, julian.maurice, kyle
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 15432: t/db_dependent/Letters.t depends on external data/configuration
Bug 15432: t/db_dependent/Letters.t depends on external data/configuration
Bug 15432: t/db_dependent/Letters.t depends on external data/configuration

Description Marc Véron 2015-12-28 14:46:12 UTC
To reproduce:
- Set system preference LetterLog to 'Don't log'
- prove t/db_dependent/Letters.t
- Result: Fails on test 62 - Successfully sent claim
- Set system preference LetterLog to 'Log
- Test again
- Result: Pass OK
Comment 1 Marc Véron 2015-12-28 15:04:58 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2015-12-30 11:37:08 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2015-12-30 11:37:44 UTC
Trivial, skipping QA.
Comment 4 Jonathan Druart 2015-12-30 11:41:17 UTC
Created attachment 46071 [details] [review]
Bug 15432: t/db_dependent/Letters.t depends on external data/configuration

To test:

- Set system preference LetterLog to 'Don't log'
- prove t/db_dependent/Letters.t
- Result: Fails on test 62 - Successfully sent claim
- Apply patch
- Test again
- Result: Pass OK

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Amended patch: removed the bug reference, not needed.
Comment 5 Kyle M Hall 2015-12-30 16:35:29 UTC
Pushed to master, thanks Marc!
Comment 6 Julian Maurice 2015-12-31 13:16:28 UTC
Patch pushed to 3.22.x, will be in 3.22.2
Comment 7 Frédéric Demians 2015-12-31 18:32:51 UTC
This patch has been pushed to 3.20.x, will be in 3.20.8.