Bug 15432 - t/db_dependent/Letters.t depends on external data/configuration
Summary: t/db_dependent/Letters.t depends on external data/configuration
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Marc Véron
QA Contact: Marc Véron
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-28 14:46 UTC by Marc Véron
Modified: 2017-06-14 22:05 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15432: t/db_dependent/Letters.t depends on external data/configuration (1.09 KB, patch)
2015-12-28 15:04 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 15432: t/db_dependent/Letters.t depends on external data/configuration (1.21 KB, patch)
2015-12-30 11:37 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 15432: t/db_dependent/Letters.t depends on external data/configuration (1.20 KB, patch)
2015-12-30 11:41 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Véron 2015-12-28 14:46:12 UTC
To reproduce:
- Set system preference LetterLog to 'Don't log'
- prove t/db_dependent/Letters.t
- Result: Fails on test 62 - Successfully sent claim
- Set system preference LetterLog to 'Log
- Test again
- Result: Pass OK
Comment 1 Marc Véron 2015-12-28 15:04:58 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2015-12-30 11:37:08 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2015-12-30 11:37:44 UTC
Trivial, skipping QA.
Comment 4 Jonathan Druart 2015-12-30 11:41:17 UTC
Created attachment 46071 [details] [review]
Bug 15432: t/db_dependent/Letters.t depends on external data/configuration

To test:

- Set system preference LetterLog to 'Don't log'
- prove t/db_dependent/Letters.t
- Result: Fails on test 62 - Successfully sent claim
- Apply patch
- Test again
- Result: Pass OK

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Amended patch: removed the bug reference, not needed.
Comment 5 Kyle M Hall 2015-12-30 16:35:29 UTC
Pushed to master, thanks Marc!
Comment 6 Julian Maurice 2015-12-31 13:16:28 UTC
Patch pushed to 3.22.x, will be in 3.22.2
Comment 7 Frédéric Demians 2015-12-31 18:32:51 UTC
This patch has been pushed to 3.20.x, will be in 3.20.8.