Summary: | Do not display links to circulation.pl if remaining_permissions is not set | ||
---|---|---|---|
Product: | Koha | Reporter: | Marc Véron <veron> |
Component: | Circulation | Assignee: | Marc Véron <veron> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | brendan, f.demians, gmcharlt, hector.hecaxmmx, julian.maurice, kyle.m.hall |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 15472: Do not display links to circulation.pl if remaining_permissions is not set
[SIGNED-OFF]Bug 15472: Do not display links to circulation.pl if remaining_permissions is not set Bug 15472: Do not display links to circulation.pl if remaining_permissions is not set |
Description
Marc Véron
2016-01-05 14:38:39 UTC
Created attachment 46265 [details] [review] Bug 15472: Do not display links to circulation.pl if remaining_permissions is not set If permission 'circulate_remaining_permissions' is not set, links to 'Circulation' (/circ/circulation-home.pl) on the intranet home page lead to an error message: "Error: You do not have permission to access this page." This patch hides the links if the permission is not set. To test: - Apply patch - Log in to the intranet (staff client) with a patron who has the permission 'circulate_remaining_pernissions' not set - Verify that no links to Circulation appear on the intranet start page (menu top left and menu in main page area) - Log in as a user who has the permission set. - Verify that te links appear as appropriate. http://bugs.koha-community.org/show_bug.cgi?id=15442 Good catch, Marc. If I want a staff patron has only access to one or two granular permissions, e.g., self_checkout, the System displays the circulation links. If patron clicks in one of the links, the program logs out the user and is presented with the error message. Created attachment 46499 [details] [review] [SIGNED-OFF]Bug 15472: Do not display links to circulation.pl if remaining_permissions is not set If permission 'circulate_remaining_permissions' is not set, links to 'Circulation' (/circ/circulation-home.pl) on the intranet home page lead to an error message: "Error: You do not have permission to access this page." This patch hides the links if the permission is not set. To test: - Apply patch - Log in to the intranet (staff client) with a patron who has the permission 'circulate_remaining_pernissions' not set - Verify that no links to Circulation appear on the intranet start page (menu top left and menu in main page area) - Log in as a user who has the permission set. - Verify that te links appear as appropriate. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Created attachment 46577 [details] [review] Bug 15472: Do not display links to circulation.pl if remaining_permissions is not set If permission 'circulate_remaining_permissions' is not set, links to 'Circulation' (/circ/circulation-home.pl) on the intranet home page lead to an error message: "Error: You do not have permission to access this page." This patch hides the links if the permission is not set. To test: - Apply patch - Log in to the intranet (staff client) with a patron who has the permission 'circulate_remaining_pernissions' not set - Verify that no links to Circulation appear on the intranet start page (menu top left and menu in main page area) - Log in as a user who has the permission set. - Verify that te links appear as appropriate. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to Master - Should be in the May 2016 release. Thanks! Patch pushed to 3.22.x, will be in 3.22.3 This patch has been pushed to 3.20.x, will be in 3.20.9. |