Bug 15472 - Do not display links to circulation.pl if remaining_permissions is not set
Summary: Do not display links to circulation.pl if remaining_permissions is not set
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Marc Véron
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-05 14:38 UTC by Marc Véron
Modified: 2017-06-14 22:11 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15472: Do not display links to circulation.pl if remaining_permissions is not set (2.77 KB, patch)
2016-01-05 15:09 UTC, Marc Véron
Details | Diff | Splinter Review
[SIGNED-OFF]Bug 15472: Do not display links to circulation.pl if remaining_permissions is not set (2.80 KB, patch)
2016-01-11 20:21 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
Bug 15472: Do not display links to circulation.pl if remaining_permissions is not set (2.86 KB, patch)
2016-01-13 11:08 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Véron 2016-01-05 14:38:39 UTC
If permisison 'remaining_permissions' is not set, links to 'Circulation' (/circ/circulation-home.pl) lead to an error message (Error: You do not have permission to access this page).
Comment 1 Marc Véron 2016-01-05 15:09:22 UTC Comment hidden (obsolete)
Comment 2 Héctor Eduardo Castro Avalos 2016-01-11 20:18:03 UTC
Good catch, Marc. If I want a staff patron has only access to one or two granular permissions, e.g., self_checkout, the System displays the circulation links. If patron clicks in one of the links, the program logs out the user and is presented with the error message.
Comment 3 Héctor Eduardo Castro Avalos 2016-01-11 20:21:11 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2016-01-13 11:08:06 UTC
Created attachment 46577 [details] [review]
Bug 15472: Do not display links to circulation.pl if remaining_permissions is not set

If permission 'circulate_remaining_permissions' is not set, links to 'Circulation'
(/circ/circulation-home.pl) on the intranet home page lead to an error
message: "Error: You do not have permission to access this page."

This patch hides the links if the permission is not set.

To test:
- Apply patch
- Log in to the intranet (staff client) with a patron who has the permission
  'circulate_remaining_pernissions' not set
- Verify that no links to Circulation appear on the intranet start page
  (menu top left and menu in main page area)
- Log in as a user who has the permission set.
- Verify that te links appear as appropriate.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Brendan Gallagher 2016-01-27 05:23:52 UTC
Pushed to Master - Should be in the May 2016 release. Thanks!
Comment 6 Julian Maurice 2016-01-29 15:18:03 UTC
Patch pushed to 3.22.x, will be in 3.22.3
Comment 7 Frédéric Demians 2016-02-12 06:46:07 UTC
This patch has been pushed to 3.20.x, will be in 3.20.9.