Bug 16074

Summary: Making frequencies actions buttons
Product: Koha Reporter: Aleisha Amohia <aleisha>
Component: SerialsAssignee: Aleisha Amohia <aleisha>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: brendan, colin.campbell, jonathan.druart
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: Sponsored Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 16074: Making frequencies actions buttons
Bug 16074: Making frequencies actions buttons
[SIGNED-OFF] Bug 16074: Making frequencies actions buttons
Bug 16074: Making frequencies actions buttons
Bug 16074: Making frequencies actions buttons
Bug 16074: Making frequencies actions buttons
Bug 16074: Replace Modify with Edit

Description Aleisha Amohia 2016-03-15 06:16:28 UTC

    
Comment 1 Aleisha Amohia 2016-03-15 06:19:10 UTC Comment hidden (obsolete)
Comment 2 Aleisha Amohia 2016-03-15 06:37:28 UTC Comment hidden (obsolete)
Comment 3 Owen Leonard 2016-03-15 12:35:12 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2016-03-16 08:25:30 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2016-03-16 08:25:46 UTC
Should not we replace "Modify" with "Edit"?
Comment 6 Aleisha Amohia 2016-03-17 22:05:55 UTC
(In reply to Jonathan Druart from comment #5)
> Should not we replace "Modify" with "Edit"?

I've always thought that 'Modify' should be 'Edit' when making patches like this but I was never sure if 'Modify' was there for a reason or not. I can easily change them all though.
Comment 7 Aleisha Amohia 2016-03-17 22:13:35 UTC Comment hidden (obsolete)
Comment 8 Jonathan Druart 2016-03-18 07:57:08 UTC
Created attachment 49297 [details] [review]
Bug 16074: Making frequencies actions buttons

To test:

1) Go to Serials -> Manage frequencies
2) Confirm that buttons 'Modify' and 'Delete' show as buttons and work
   as expected
3) Confirm that when you make your window narrow, the column with the
   buttons does not wrap
4) Confirm that column heading is now 'Actions'

Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Buttons look correct and work correctly.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 9 Jonathan Druart 2016-03-18 07:57:53 UTC
Created attachment 49298 [details] [review]
Bug 16074: Replace Modify with Edit

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 10 Jonathan Druart 2016-03-18 07:59:42 UTC
Aleisha, when a bug report has passed qa, please do not modify patches which have been signed off/QAed.
The best is to provide a follow-up: the changes are easier to read and you won't need to request another signoff.
Comment 11 Aleisha Amohia 2016-03-18 08:00:48 UTC
(In reply to Jonathan Druart from comment #10)
> Aleisha, when a bug report has passed qa, please do not modify patches which
> have been signed off/QAed.
> The best is to provide a follow-up: the changes are easier to read and you
> won't need to request another signoff.

I was wondering about that! Thanks for letting me know :)
Comment 12 Brendan Gallagher 2016-03-23 19:26:38 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!