Created attachment 49156 [details] [review] Bug 16074: Making frequencies actions buttons To test: 1) Go to Serials -> Manage frequencies 2) Confirm that buttons 'Modify' and 'Delete' show as buttons and work as expected 3) Confirm that when you make your window narrow, the column with the buttons does not wrap Sponsored-by: Catalyst IT
Created attachment 49158 [details] [review] Bug 16074: Making frequencies actions buttons To test: 1) Go to Serials -> Manage frequencies 2) Confirm that buttons 'Modify' and 'Delete' show as buttons and work as expected 3) Confirm that when you make your window narrow, the column with the buttons does not wrap 4) Confirm that column heading is now 'Actions' Sponsored-by: Catalyst IT
Created attachment 49169 [details] [review] [SIGNED-OFF] Bug 16074: Making frequencies actions buttons To test: 1) Go to Serials -> Manage frequencies 2) Confirm that buttons 'Modify' and 'Delete' show as buttons and work as expected 3) Confirm that when you make your window narrow, the column with the buttons does not wrap 4) Confirm that column heading is now 'Actions' Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Buttons look correct and work correctly.
Created attachment 49199 [details] [review] Bug 16074: Making frequencies actions buttons To test: 1) Go to Serials -> Manage frequencies 2) Confirm that buttons 'Modify' and 'Delete' show as buttons and work as expected 3) Confirm that when you make your window narrow, the column with the buttons does not wrap 4) Confirm that column heading is now 'Actions' Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Buttons look correct and work correctly. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Should not we replace "Modify" with "Edit"?
(In reply to Jonathan Druart from comment #5) > Should not we replace "Modify" with "Edit"? I've always thought that 'Modify' should be 'Edit' when making patches like this but I was never sure if 'Modify' was there for a reason or not. I can easily change them all though.
Created attachment 49285 [details] [review] Bug 16074: Making frequencies actions buttons EDIT: Changing 'Modify' to 'Edit' To test: 1) Go to Serials -> Manage frequencies 2) Confirm that links 'Modify' and 'Delete' show as buttons ('Edit' instead of 'Modify') and work as expected 3) Confirm that when you make your window narrow, the column with the buttons does not wrap 4) Confirm that column heading is now 'Actions' 5) Confirm that when you click on Edit for any frequency, the title of the page is now 'Edit frequency' Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Buttons look correct and work correctly. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 49297 [details] [review] Bug 16074: Making frequencies actions buttons To test: 1) Go to Serials -> Manage frequencies 2) Confirm that buttons 'Modify' and 'Delete' show as buttons and work as expected 3) Confirm that when you make your window narrow, the column with the buttons does not wrap 4) Confirm that column heading is now 'Actions' Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Buttons look correct and work correctly. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 49298 [details] [review] Bug 16074: Replace Modify with Edit Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Aleisha, when a bug report has passed qa, please do not modify patches which have been signed off/QAed. The best is to provide a follow-up: the changes are easier to read and you won't need to request another signoff.
(In reply to Jonathan Druart from comment #10) > Aleisha, when a bug report has passed qa, please do not modify patches which > have been signed off/QAed. > The best is to provide a follow-up: the changes are easier to read and you > won't need to request another signoff. I was wondering about that! Thanks for letting me know :)
Pushed to Master - Should be in the May 2016 release. Thanks!