Summary: | db_structure.t shouldn't have a fixed number of tests | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi <tomascohen> |
Component: | Test Suite | Assignee: | Tomás Cohen Arazi <tomascohen> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | brendan, m.de.rooy |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 16173: db_structure.t shouldn't have a fixed number of tests
Bug 16173: db_structure.t shouldn't have a fixed number of tests Bug 16173: db_structure.t shouldn't have a fixed number of tests |
Description
Tomás Cohen Arazi
2016-03-30 15:46:12 UTC
Created attachment 49689 [details] [review] Bug 16173: db_structure.t shouldn't have a fixed number of tests This patch makes db_structure.t more flexible regarding how many tests are run. This is important because it would fail on each db structure change, masking potential real problems. To test: - Run $ prove t/db_dependent/db_structure.t => FAIL: the number of tests ran doesn't match what is expected - Apply the patch - Run $ prove t/db_dependent/db_structure.t => SUCCESS: Tests count is not an issue [1] - Sign off [1] Right now the tests run successfuly, they might fail if a real bug is introduced on the DB structure, in the meantime. Comment on attachment 49689 [details] [review] Bug 16173: db_structure.t shouldn't have a fixed number of tests Review of attachment 49689 [details] [review]: ----------------------------------------------------------------- ::: t/db_dependent/db_structure.t @@ +12,5 @@ > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License > +# along with Koha; if not, see <http://www.gnu.org/licenses>. Beyond scope, but good idea to fix anyways. :) Created attachment 49705 [details] [review] Bug 16173: db_structure.t shouldn't have a fixed number of tests This patch makes db_structure.t more flexible regarding how many tests are run. This is important because it would fail on each db structure change, masking potential real problems. To test: - Run $ prove t/db_dependent/db_structure.t => FAIL: the number of tests ran doesn't match what is expected - Apply the patch - Run $ prove t/db_dependent/db_structure.t => SUCCESS: Tests count is not an issue [1] - Sign off [1] Right now the tests run successfuly, they might fail if a real bug is introduced on the DB structure, in the meantime. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 49775 [details] [review] Bug 16173: db_structure.t shouldn't have a fixed number of tests This patch makes db_structure.t more flexible regarding how many tests are run. This is important because it would fail on each db structure change, masking potential real problems. To test: - Run $ prove t/db_dependent/db_structure.t => FAIL: the number of tests ran doesn't match what is expected - Apply the patch - Run $ prove t/db_dependent/db_structure.t => SUCCESS: Tests count is not an issue [1] - Sign off [1] Right now the tests run successfuly, they might fail if a real bug is introduced on the DB structure, in the meantime. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to Master - Should be in the May 2016 release. Thanks! |