Right now, this file contains a fixed number of tests. So any structure change on the relevant tables should taouch this file to adjust the number to what it expects. The point of tests is that they reflect problems, not cause them :-D So this specific tests file should not have a fixed number of tests, and it will serve its purpose by comparing the table vs deletedtable cases no matter how many columns they have.
Created attachment 49689 [details] [review] Bug 16173: db_structure.t shouldn't have a fixed number of tests This patch makes db_structure.t more flexible regarding how many tests are run. This is important because it would fail on each db structure change, masking potential real problems. To test: - Run $ prove t/db_dependent/db_structure.t => FAIL: the number of tests ran doesn't match what is expected - Apply the patch - Run $ prove t/db_dependent/db_structure.t => SUCCESS: Tests count is not an issue [1] - Sign off [1] Right now the tests run successfuly, they might fail if a real bug is introduced on the DB structure, in the meantime.
Comment on attachment 49689 [details] [review] Bug 16173: db_structure.t shouldn't have a fixed number of tests Review of attachment 49689 [details] [review]: ----------------------------------------------------------------- ::: t/db_dependent/db_structure.t @@ +12,5 @@ > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License > +# along with Koha; if not, see <http://www.gnu.org/licenses>. Beyond scope, but good idea to fix anyways. :)
Created attachment 49705 [details] [review] Bug 16173: db_structure.t shouldn't have a fixed number of tests This patch makes db_structure.t more flexible regarding how many tests are run. This is important because it would fail on each db structure change, masking potential real problems. To test: - Run $ prove t/db_dependent/db_structure.t => FAIL: the number of tests ran doesn't match what is expected - Apply the patch - Run $ prove t/db_dependent/db_structure.t => SUCCESS: Tests count is not an issue [1] - Sign off [1] Right now the tests run successfuly, they might fail if a real bug is introduced on the DB structure, in the meantime. Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 49775 [details] [review] Bug 16173: db_structure.t shouldn't have a fixed number of tests This patch makes db_structure.t more flexible regarding how many tests are run. This is important because it would fail on each db structure change, masking potential real problems. To test: - Run $ prove t/db_dependent/db_structure.t => FAIL: the number of tests ran doesn't match what is expected - Apply the patch - Run $ prove t/db_dependent/db_structure.t => SUCCESS: Tests count is not an issue [1] - Sign off [1] Right now the tests run successfuly, they might fail if a real bug is introduced on the DB structure, in the meantime. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to Master - Should be in the May 2016 release. Thanks!