Summary: | t/db_dependent/Reports_Guided.t is failing | ||
---|---|---|---|
Product: | Koha | Reporter: | Mark Tompsett <mtompset> |
Component: | Reports | Assignee: | Mark Tompsett <mtompset> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | brendan, julian.maurice, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 16185: t/db_dependent/Reports_Guided.t is failing
Bug 16185: t/db_dependent/Reports_Guided.t is failing |
Description
Mark Tompsett
2016-04-01 13:34:03 UTC
Turns out my perlcritic happiness tendency found a solution. Scalar was being used as a function. Removing function-like bracketing fixed the issue. Created attachment 49784 [details] [review] Bug 16185: t/db_dependent/Reports_Guided.t is failing TEST PLAN --------- 1) prove t/db_dependent/Reports_Guided.t -- fails -- note the failure has a scalar function-like bracketing 2) apply patch 3) prove t/db_dependent/Reports_Guided.t -- passes 4) git diff origin/master -- note all scalars have been changed to not have function-like brackets which could be incorrectly parsed. 5) run koha qa test tools Created attachment 49795 [details] [review] Bug 16185: t/db_dependent/Reports_Guided.t is failing TEST PLAN --------- 1) prove t/db_dependent/Reports_Guided.t -- fails -- note the failure has a scalar function-like bracketing 2) apply patch 3) prove t/db_dependent/Reports_Guided.t -- passes 4) git diff origin/master -- note all scalars have been changed to not have function-like brackets which could be incorrectly parsed. 5) run koha qa test tools Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar> Pushed to Master - Should be in the May 2016 release. Thanks! Patch pushed to 3.22.x, will be in 3.22.6 |