Bug 16185 - t/db_dependent/Reports_Guided.t is failing
Summary: t/db_dependent/Reports_Guided.t is failing
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Mark Tompsett
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-01 13:34 UTC by Mark Tompsett
Modified: 2016-12-05 21:25 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16185: t/db_dependent/Reports_Guided.t is failing (2.52 KB, patch)
2016-04-01 13:47 UTC, Mark Tompsett
Details | Diff | Splinter Review
Bug 16185: t/db_dependent/Reports_Guided.t is failing (2.58 KB, patch)
2016-04-01 15:09 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Tompsett 2016-04-01 13:34:03 UTC
"t_db_dependent_Reports_Guided_t.filter takes report id (661)"
http://jenkins.koha-community.org/view/Koha%20master/job/Koha_Master_D7/680/testReport/

prove t/db_dependent/Reports_Guided.t should run successfully.
Comment 1 Mark Tompsett 2016-04-01 13:37:13 UTC
Turns out my perlcritic happiness tendency found a solution. Scalar was being used as a function. Removing function-like bracketing fixed the issue.
Comment 2 Mark Tompsett 2016-04-01 13:47:59 UTC Comment hidden (obsolete)
Comment 3 Tomás Cohen Arazi 2016-04-01 15:09:26 UTC
Created attachment 49795 [details] [review]
Bug 16185: t/db_dependent/Reports_Guided.t is failing

TEST PLAN
---------
1) prove t/db_dependent/Reports_Guided.t
   -- fails
   -- note the failure has a scalar function-like bracketing
2) apply patch
3) prove t/db_dependent/Reports_Guided.t
   -- passes
4) git diff origin/master
   -- note all scalars have been changed to not have
      function-like brackets which could be incorrectly
      parsed.
5) run koha qa test tools

Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
Comment 4 Brendan Gallagher 2016-04-01 19:14:00 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!
Comment 5 Julian Maurice 2016-04-06 15:07:52 UTC
Patch pushed to 3.22.x, will be in 3.22.6