Summary: | Remove the use of "onclick" from circulation and fine rules template | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | System Administration | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | gmcharlt, hayleypelham, katrin.fischer, kyle, testopia, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/admin/smart-rules.pl | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 15456 | ||
Bug Blocks: | 17858 | ||
Attachments: |
Bug 16300 - Remove the use of "onclick" from circulation and fine rules template
Bug 16300 - Remove the use of "onclick" from circulation and fine rules template |
Description
Owen Leonard
2016-04-19 18:23:40 UTC
Created attachment 50435 [details] [review] Bug 16300 - Remove the use of "onclick" from circulation and fine rules template This patch updates the circulation and fine rules template so that the "clear" button does not require an "onclick" attribute. To test, apply the patch and go to Administration -> Circulation and fine rules. - Edit an existing rule. - Click the "Clear" button and confirm. The entry form should be reset to its blank state. - Click the "Clear" button and cancel. The entry form should remain the same. Created attachment 50453 [details] [review] Bug 16300 - Remove the use of "onclick" from circulation and fine rules template This patch updates the circulation and fine rules template so that the "clear" button does not require an "onclick" attribute. To test, apply the patch and go to Administration -> Circulation and fine rules. - Edit an existing rule. - Click the "Clear" button and confirm. The entry form should be reset to its blank state. - Click the "Clear" button and cancel. The entry form should remain the same. Signed-off-by: Marc Véron <veron@veron.ch> Hi Owen, looking at this, maybe it would make sense to redo the patch without the dependency on 15456. What do you think? Moving to PDA for now. This look to have been remedied on master. Setting to Resolved. |