Bug 15456 - Fix tabs and inconsistent indentation in smart-rules.tt
Summary: Fix tabs and inconsistent indentation in smart-rules.tt
Status: BLOCKED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Jesse Weaver
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 16300
  Show dependency treegraph
 
Reported: 2015-12-31 19:47 UTC by Jesse Weaver
Modified: 2016-04-29 14:21 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15456: Fix tabs and inconsistent indentation in smart-rules.tt (15.10 KB, patch)
2015-12-31 19:52 UTC, Jesse Weaver
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 15456: Fix tabs and inconsistent indentation in smart-rules.tt (15.23 KB, patch)
2016-01-04 23:29 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
Bug 15456: Fix tabs and inconsistent indentation in smart-rules.tt (15.28 KB, patch)
2016-01-08 18:37 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 15456: Fix tabs and inconsistent indentation in smart-rules.tt (15.79 KB, patch)
2016-04-18 22:13 UTC, Jesse Weaver
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 15456: Fix tabs and inconsistent indentation in smart-rules.tt (15.88 KB, patch)
2016-04-19 14:48 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Weaver 2015-12-31 19:47:16 UTC

    
Comment 1 Jesse Weaver 2015-12-31 19:52:24 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2016-01-04 23:29:34 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-01-07 11:18:37 UTC
There are patches in the queue waiting for SO and QA. I would prefer to wait before pushing this patch.
Comment 4 Kyle M Hall 2016-01-08 18:37:38 UTC Comment hidden (obsolete)
Comment 5 Katrin Fischer 2016-01-10 22:14:17 UTC
I looked it up with the splitter tool: 
bug 8367 - needs sign-off
bug 15407 - needs sign-off
bug 15354 - passed qa
bug 9805 - failed qa
bug 14695 - failed qa

I'd like to wait a bit too - there is currently no new work dependent on the clean-up and it will make it harder for other patches.
Comment 6 Brendan Gallagher 2016-03-02 22:46:01 UTC
Didn't apply cleanly - I know because of the moving target that master is.  Please rebase.  Once it's done - leave me an @later in #koha and I'll jump right on it.  Thank you so much for the time and bother of rebasing.

Brendan
Comment 7 Jesse Weaver 2016-04-18 22:13:52 UTC Comment hidden (obsolete)
Comment 8 Owen Leonard 2016-04-19 14:48:52 UTC
Created attachment 50417 [details] [review]
[SIGNED-OFF] Bug 15456: Fix tabs and inconsistent indentation in smart-rules.tt

To verify patch, run `git diff -w HEAD^' and note that the only changes
shown are where [% IF %] statements are expanded/unexpanded onto
multiple lines to match the prevailing style.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Looks like refactoring :)
No regressions, no koha-qa errors

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 9 Katrin Fischer 2016-04-25 09:52:04 UTC
There are still a lot of patches visible on splitter that also want to modify this file - will hold off this for a bit.

http://splitter.koha-community.org/files - search for smart-rules
Comment 10 Jonathan Druart 2016-04-29 14:21:36 UTC
Moving this outside of the QA queue.