Bug 16337

Summary: Remove the use of "onclick" from the stage MARC records template
Product: Koha Reporter: Owen Leonard <oleonard>
Component: ToolsAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: gmcharlt, kyle, testopia, veron
Version: Main   
Hardware: All   
OS: All   
URL: /cgi-bin/koha/tools/stage-marc-import.pl
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 16468    
Attachments: Bug 16337 - Remove the use of "onclick" from the stage MARC records template
[SIGNED-OFF] Bug 16337 - Remove the use of "onclick" from the stage MARC records template
[PASSED QA] Bug 16337 - Remove the use of "onclick" from the stage MARC records template

Description Owen Leonard 2016-04-25 14:40:03 UTC
There are a couple of instances of "onclick" in stage-marc-import.tt which can be removed in favor of defining events in the JavaScript.
Comment 1 Owen Leonard 2016-04-25 14:43:58 UTC Comment hidden (obsolete)
Comment 2 Aleisha Amohia 2016-04-25 23:19:33 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2016-04-27 08:36:36 UTC
Created attachment 50789 [details] [review]
[PASSED QA] Bug 16337 - Remove the use of "onclick" from the stage MARC records template

This patch reviseds the stage MARC records template, removing "onclick"
attributes from the markup and defining those events in the script.

To test, apply the patch and go to Tools -> Stage MARC records for
import.

- Select a MARC file for import.
- Click the "Upload file" button. Your upload should be processed
  correctly.
- Select a MARC file for import.
- Click the "Upload file" button.
- Click the "Cancel" button before the file has been uploaded. The
  upload should be cancelled.

Signed-off-by: Aleisha <aleishaamohia@hotmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Kyle M Hall 2016-04-29 16:46:25 UTC
Pushed to master for the 16.05 release. Thanks Owen!