There is one more instance of "onclick" in stage-marc-import.tt which I didn't catch in Bug 16337 somehow. It can be removed in favor of defining events in the JavaScript.
Created attachment 51296 [details] [review] Bug 16468 - Remove last "onclick" from the stage MARC records template This patch reviseds the stage MARC records template, removing one more "onclick" attribute from the markup and defining that event in the script. This patch also corrects a missing quotation mark in the HTML. I have done some reindentation to that section. To test, apply the patch and go to Tools -> Stage MARC records for import. - Select a MARC file for import. - Click the "Upload file" button. - Click the "Stage for import" button. Your import should be correctly staged.
Created attachment 52012 [details] [review] Bug 16468 - Remove last "onclick" from the stage MARC records template This patch reviseds the stage MARC records template, removing one more "onclick" attribute from the markup and defining that event in the script. This patch also corrects a missing quotation mark in the HTML. I have done some reindentation to that section. To test, apply the patch and go to Tools -> Stage MARC records for import. - Select a MARC file for import. - Click the "Upload file" button. - Click the "Stage for import" button. Your import should be correctly staged. Signed-off-by: Claire Gravely <c.gravely@arts.ac.uk>
Created attachment 52650 [details] [review] Bug 16468 - Remove last "onclick" from the stage MARC records template This patch reviseds the stage MARC records template, removing one more "onclick" attribute from the markup and defining that event in the script. This patch also corrects a missing quotation mark in the HTML. I have done some reindentation to that section. To test, apply the patch and go to Tools -> Stage MARC records for import. - Select a MARC file for import. - Click the "Upload file" button. - Click the "Stage for import" button. Your import should be correctly staged. Signed-off-by: Claire Gravely <c.gravely@arts.ac.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 16.11, thanks Owen!
Pushed in 16.05. Will be in 16.05.02.