Summary: | Remove the use of "onclick" from the lists template | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Lists | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | gmcharlt, kyle, m.de.rooy, testopia, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/virtualshelves/shelves.pl | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 16338 - Remove the use of "onclick" from the lists template
[SIGNED-OFF] Bug 16338 - Remove the use of "onclick" from the lists template [PASSED QA] Bug 16338 - Remove the use of "onclick" from the lists template |
Description
Owen Leonard
2016-04-25 14:49:44 UTC
Created attachment 50641 [details] [review] Bug 16338 - Remove the use of "onclick" from the lists template This patch removes the use of "onclick" from the list delete button, moving the event definition into the script. Also changed: Removed some unnecessary link markup; Added some whitespace around the action buttons. To test, apply the patch and go to Lists. Click the "Delete" button next to any list. You should be prompted to confirm the deletion. Verify that both confirming and canceling the deletion works correctly. Created attachment 50687 [details] [review] [SIGNED-OFF] Bug 16338 - Remove the use of "onclick" from the lists template This patch removes the use of "onclick" from the list delete button, moving the event definition into the script. Also changed: Removed some unnecessary link markup; Added some whitespace around the action buttons. To test, apply the patch and go to Lists. Click the "Delete" button next to any list. You should be prompted to confirm the deletion. Verify that both confirming and canceling the deletion works correctly. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Created attachment 50788 [details] [review] [PASSED QA] Bug 16338 - Remove the use of "onclick" from the lists template This patch removes the use of "onclick" from the list delete button, moving the event definition into the script. Also changed: Removed some unnecessary link markup; Added some whitespace around the action buttons. To test, apply the patch and go to Lists. Click the "Delete" button next to any list. You should be prompted to confirm the deletion. Verify that both confirming and canceling the deletion works correctly. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for the 16.05 release. Thanks Owen! |