Bug 16338 - Remove the use of "onclick" from the lists template
Summary: Remove the use of "onclick" from the lists template
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Lists (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/virtualshelves/shelves.pl
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-25 14:49 UTC by Owen Leonard
Modified: 2016-12-05 21:27 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16338 - Remove the use of "onclick" from the lists template (4.14 KB, patch)
2016-04-25 14:53 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 16338 - Remove the use of "onclick" from the lists template (4.17 KB, patch)
2016-04-25 23:18 UTC, Aleisha Amohia
Details | Diff | Splinter Review
[PASSED QA] Bug 16338 - Remove the use of "onclick" from the lists template (4.22 KB, patch)
2016-04-27 08:30 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2016-04-25 14:49:44 UTC
This is one instance of "onclick" in the lists template. It should be removed in favor of defining the event in the script.
Comment 1 Owen Leonard 2016-04-25 14:53:28 UTC Comment hidden (obsolete)
Comment 2 Aleisha Amohia 2016-04-25 23:18:00 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2016-04-27 08:30:48 UTC
Created attachment 50788 [details] [review]
[PASSED QA] Bug 16338 - Remove the use of "onclick" from the lists template

This patch removes the use of "onclick" from the list delete button,
moving the event definition into the script.

Also changed: Removed some unnecessary link markup; Added some
whitespace around the action buttons.

To test, apply the patch and go to Lists.

Click the "Delete" button next to any list. You should be prompted to
confirm the deletion. Verify that both confirming and canceling the
deletion works correctly.

Signed-off-by: Aleisha <aleishaamohia@hotmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Kyle M Hall 2016-04-29 16:43:28 UTC
Pushed to master for the 16.05 release. Thanks Owen!