Description
Danielle Elder
2016-04-25 20:23:06 UTC
Created attachment 50950 [details]
Marc record with multiple 7XX heading to test
Created attachment 50952 [details] [review] Bug 16343: 7XX XSLT subfields displaying out of order Patch apply for OPAC: This patch respect previous css classes .authordates and .relatorcode but also include .titleportion .authordates {display: none;} .titleportion {display: none;} .relatorcode {display: none;} To test: - Stage the record attached - Reindex zebra - Leave empty the OPACUserCSS syspref - Go to the new record in OPAC detail page - Look the wrong display of dates - Apply patch and refresh the page - Test in OPACUserCSS the css stated before - Play deleting or adding the clasess >Playing with the three classes: By: International Congress of Gerontology. Satellite Conference (1978 : Sydney, N.S.W.). Contributor(s): Weinman, Sarah | Caspary, Vera | Eustis, Helen | Hughes, Dorothy B. (Dorothy Belle) >"ith: .titleportion and .relatorcode By: International Congress of Gerontology. Satellite Conference (1978 : Sydney, N.S.W.). Contributor(s): Weinman, Sarah | Caspary, Vera, 1899-1987 | Eustis, Helen | Hughes, Dorothy B. (Dorothy Belle), 1904-1993 >Only title portion International Congress of Gerontology. Satellite Conference (1978 : Sydney, N.S.W.) [depicted.]. Contributor(s): Weinman, Sarah [editor of compilation.] | Caspary, Vera, 1899-1987 | Eustis, Helen | Hughes, Dorothy B. (Dorothy Belle), 1904-1993 >Without classes By: International Congress of Gerontology. Satellite Conference (1978 : Sydney, N.S.W.) [depicted.]. Contributor(s): Weinman, Sarah. [editor of compilation.] | Caspary, Vera, 1899-1987. Laura | Eustis, Helen. The horizontal man | Hughes, Dorothy B. (Dorothy Belle), 1904-1993. In a lonely place Notice that you can play with another sort of combination Created attachment 51045 [details] [review] Bug 16343: 7XX XSLT subfields displaying out of order Patch apply for OPAC: This patch respect previous css classes .authordates and .relatorcode but also include .titleportion .authordates {display: none;} .titleportion {display: none;} .relatorcode {display: none;} To test: - Stage the record attached - Reindex zebra - Leave empty the OPACUserCSS syspref - Go to the new record in OPAC detail page - Look the wrong display of dates - Apply patch and refresh the page - Test in OPACUserCSS the css stated before - Play deleting or adding the clasess Signed-off-by: Dani Elder <danielle@bywatersolutions.com> Thanks for the quick response, Héctor. Created attachment 51118 [details]
Two MARC21 records to test with multiples 7XX fields
Created attachment 51119 [details] [review] Bug 16343: 7XX XSLT subfields displaying out of order This patch respect previous css classes .authordates and .relatorcode but also include .titleportion .authordates {display: none;} .titleportion {display: none;} .relatorcode {display: none;} To test: - Stage the two record attached wit titles: - Surface & coatings technology. - Women crime writers - Reindex zebra (necessary to Opac and Itranet results) - Leave empty the OPACUserCSS and IntranetUserCSS sysprefs - Go to the new records in OPAC and Intranet detail page - Look the wrong display of dates - Apply patch and refresh the page - Test in OPACUserCSS and IntranetUserCSS the css stated before - Play deleting or adding the classes - Test with multiple records with 700 (with and without dates, etc; 710 and 711) NOTE: dates in 710 and 711 can be hidden with .titleportion class dates in this kind of heading go with another data for example: Catholic Church. Plenary Council of Baltimore (2nd : 1866) (In reply to Danielle Elder from comment #5) > Thanks for the quick response, Héctor. Hi Danielle I attach a new patch with more changes, I've included new things to the patch, fix some mistake and also added the changes to Intranet and OPAC results. There is a new marc file with two records, staged for test purposes. Tanks for you test and sign-off Regards (In reply to Héctor Eduardo Castro Avalos from comment #8) > > Tanks for you test and sign-off Please re-test and re-sing-off Ok. I am going to retest and check Intranet this time. I only checked OPAC first test. Created attachment 51190 [details] [review] Bug 16343: 7XX XSLT subfields displaying out of order This patch respect previous css classes .authordates and .relatorcode but also include .titleportion .authordates {display: none;} .titleportion {display: none;} .relatorcode {display: none;} To test: - Stage the two record attached with titles: - Surface & coatings technology. - Women crime writers. - Reindex zebra (necessary to Opac and Itranet results) - Leave empty the OPACUserCSS and IntranetUserCSS sysprefs - Go to the new records in OPAC and Intranet detail page - See the wrong display of dates - Apply patch and refresh the page - Test in OPACUserCSS and IntranetUserCSS the css stated before - Play deleting or adding the classes - Test with multiple records with 700 (with and without dates, etc; 710 and 711) NOTE: dates in 710 and 711 can be hidden with .titleportion class; dates in this kind of heading go with another data for example: Catholic Church. Plenary Council of Baltimore (2nd : 1866) Patch rebased some typos fixed in comments Hi Danielle I rebase the patch with some typos fixed Sorry for the inconvenience Created attachment 51225 [details] [review] Bug 16343: 7XX XSLT subfields displaying out of order This patch respect previous css classes .authordates and .relatorcode but also include .titleportion .authordates {display: none;} .titleportion {display: none;} .relatorcode {display: none;} To test: - Stage the two record attached with titles: - Surface & coatings technology. - Women crime writers. - Reindex zebra (necessary to Opac and Itranet results) - Leave empty the OPACUserCSS and IntranetUserCSS sysprefs - Go to the new records in OPAC and Intranet detail page - See the wrong display of dates - Apply patch and refresh the page - Test in OPACUserCSS and IntranetUserCSS the css stated before - Play deleting or adding the classes - Test with multiple records with 700 (with and without dates, etc; 710 and 711) NOTE: dates in 710 and 711 can be hidden with .titleportion class; dates in this kind of heading go with another data for example: Catholic Church. Plenary Council of Baltimore (2nd : 1866) Patch rebased some typos fixed in comments Created attachment 51226 [details] [review] Bug 16343: 7XX XSLT subfields displaying out of order This patch respect previous css classes .authordates and .relatorcode but also include .titleportion .authordates {display: none;} .titleportion {display: none;} .relatorcode {display: none;} To test: - Stage the two record attached with titles: - Surface & coatings technology. - Women crime writers. - Reindex zebra (necessary to Opac and Itranet results) - Leave empty the OPACUserCSS and IntranetUserCSS sysprefs - Go to the new records in OPAC and Intranet detail page - See the wrong display of dates - Apply patch and refresh the page - Test in OPACUserCSS and IntranetUserCSS the css stated before - Play deleting or adding the classes - Test with multiple records with 700 (with and without dates, etc; 710 and 711) NOTE: dates in 710 and 711 can be hidden with .titleportion class; dates in this kind of heading go with another data for example: Catholic Church. Plenary Council of Baltimore (2nd : 1866) Patch rebased some typos fixed in comments Signed-off-by: Dani Elder <danielle@bywatersolutions.com> I tested the css classes and ordering in Intranet and OPAC. Looked great. I signed off. Hi Danielle, you forgot to change the bug status Status is signed off. Do you mean in giz bz? (I am a novice here, so let me know). Hi Hector, thx a lot for taking the time to work on this! Reading the XSLT is quite hard, but in my tests it looked alright. I am not sure this was the way of fix Winona had thought of - I'd love to get her opinion. Is it intentional to not display 100$t any longer with this patch? Can you please check? It displays without this patch, 700$t displays with and without, but sequence is fixed. *** Bug 16475 has been marked as a duplicate of this bug. *** (In reply to Katrin Fischer from comment #19) > Is it intentional to not display 100$t any longer with this patch? Can you > please check? It displays without this patch, 700$t displays with and > without, but sequence is fixed. Hi Katrin. I intencional did it since subfield $t is only used in 7XX fields in MARC bibliographic. This subfield is only used in MARC authority. If a librarian use some authorized access point with $t (name-title) subfield in bib record, the uniform title is placed in 240$a field. But if some library use 1XX$t I can include it. Regards PS: This is a policy that Library of Congress don't want to change neither LCRI nor LC-PCC PS Created attachment 51613 [details] [review] [PASSED QA] Bug 16343: 7XX XSLT subfields displaying out of order This patch respect previous css classes .authordates and .relatorcode but also include .titleportion .authordates {display: none;} .titleportion {display: none;} .relatorcode {display: none;} To test: - Stage the two record attached with titles: - Surface & coatings technology. - Women crime writers. - Reindex zebra (necessary to Opac and Itranet results) - Leave empty the OPACUserCSS and IntranetUserCSS sysprefs - Go to the new records in OPAC and Intranet detail page - See the wrong display of dates - Apply patch and refresh the page - Test in OPACUserCSS and IntranetUserCSS the css stated before - Play deleting or adding the classes - Test with multiple records with 700 (with and without dates, etc; 710 and 711) NOTE: dates in 710 and 711 can be hidden with .titleportion class; dates in this kind of heading go with another data for example: Catholic Church. Plenary Council of Baltimore (2nd : 1866) Patch rebased some typos fixed in comments Signed-off-by: Dani Elder <danielle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for Koha 16.05, thanks Hector! Patch pushed to 3.22.x, will be in 3.22.8 |