Bug 15100 - MARC21: Display of $d for 7xx and 1xx fields should be optional
Summary: MARC21: Display of $d for 7xx and 1xx fields should be optional
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Katrin Fischer
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 16343
  Show dependency treegraph
 
Reported: 2015-11-01 20:23 UTC by Katrin Fischer
Modified: 2016-12-05 21:25 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 15100 - MARC21: Display of $d for 7xx and 1xx fields should be optional (2.40 KB, patch)
2015-11-08 05:15 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
Bug 15100 - MARC21: Display of $d for 7xx and 1xx fields should be optional (3.46 KB, patch)
2015-11-08 05:28 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
Bug 15100: MARC21 - make display of "Dates associated with a name" optional (9.26 KB, patch)
2015-11-21 23:43 UTC, Katrin Fischer
Details | Diff | Splinter Review
[SIGNED-OFF]Bug 15100: MARC21 - make display of "Dates associated with a name" optional (9.35 KB, patch)
2015-11-23 03:52 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
Bug 15100: MARC21 - make display of "Dates associated with a name" optional (9.39 KB, patch)
2016-01-07 23:44 UTC, Jesse Weaver
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2015-11-01 20:23:15 UTC
With some of the changes done for 3.22 we have started displaying $d for 7xx and 1xx fields in the OPAC.

$d - Dates associated with a name (NR)

Example:

Record:
700 	1 		
_aMustermann, Karin
_d1909-2002

Display:
Contributor(s): Mustermann, Karin 1909-2002

There is no way to hide the $d. We should at least add a span with a class to make this possible.
Comment 1 Héctor Eduardo Castro Avalos 2015-11-08 05:15:55 UTC Comment hidden (obsolete)
Comment 2 Héctor Eduardo Castro Avalos 2015-11-08 05:28:34 UTC Comment hidden (obsolete)
Comment 3 Frédéric Demians 2015-11-09 10:00:30 UTC
This is not what Katrin is asking for. Some libraries may want to display author dates, some others may not want. Your patch just remove $d. The idea is to display the dates in an identified html <span> in order to allow libraries to hide author dates easily with css.
Comment 4 Héctor Eduardo Castro Avalos 2015-11-10 02:45:39 UTC
(In reply to Frédéric Demians from comment #3)
> This is not what Katrin is asking for. Some libraries may want to display
> author dates, some others may not want. Your patch just remove $d. The idea
> is to display the dates in an identified html <span> in order to allow
> libraries to hide author dates easily with css.

Does this need a syspref? or how to control the class to hide or show the span tag?

Please explain to me? Exist information about or one bug to take as example

Regards
Comment 5 Frédéric Demians 2015-11-10 07:09:28 UTC
> Does this need a syspref? or how to control the class to hide or show the
> span tag?

No syspref. You'd just need to enclose 100/70x date subfield into html <span>
with a class identifying it precisely. For example:

  <span class="authordates">1802-1885</span>

You have an example with author $4 subfield.
Comment 6 Katrin Fischer 2015-11-21 23:43:45 UTC Comment hidden (obsolete)
Comment 7 Katrin Fischer 2015-11-21 23:45:23 UTC
Hi Héctor, thx for taking a look at this! Hope it's ok, I have attached another patch that treats $d separately from the other subfields.
Comment 8 Héctor Eduardo Castro Avalos 2015-11-23 03:52:08 UTC Comment hidden (obsolete)
Comment 9 Jesse Weaver 2016-01-07 23:44:13 UTC
Created attachment 46412 [details] [review]
Bug 15100: MARC21 - make display of "Dates associated with a name" optional

With the changes for RDA now more subfields for the fields
100, 110, 111, and 700, 710, 711 are displayed.
One of them is $d - Dates associated with a name

This patch adds separate treatment of the $d subfield and
wraps it in a span with the class "authordates".
This makes it possible to hide the information with CSS.

To test:
- Make sure you have several records with $d catalogued
- Check the display in result list and detail page
  with and without the page.
- Check, if there is a difference in display
- Check if the dates are correctly wrapped in a span
- Try to hide the information, using the following
  entry in your *UserCSS preferences:
  .authordates { display: none; }

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised

Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
Comment 10 Brendan Gallagher 2016-01-27 04:28:06 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!
Comment 11 Julian Maurice 2016-01-29 14:40:37 UTC
Patch pushed to 3.22.x, will be in 3.22.3