Summary: | Error when trying to receive a new shipment without specifying invoice number | ||
---|---|---|---|
Product: | Koha | Reporter: | Aleisha Amohia <aleisha> |
Component: | Acquisitions | Assignee: | Aleisha Amohia <aleisha> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | katrin.fischer, kyle, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | Sponsored | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 16351: Making invoice number a required field
Bug 16351: Making invoice number a required field Bug 16351: Making invoice number a required field [PASSED QA] Bug 16351: Making invoice number a required field |
Description
Aleisha Amohia
2016-04-26 01:27:09 UTC
Created attachment 50692 [details] [review] Bug 16351: Making invoice number a required field To test: 1) Go to Acqui -> Do a vendor search 2) Receive a shipment 3) Attempt to click 'Next' without specifying invoice number. Notice error. 4) Go back to vendor search then apply patch. Click Receive shipment 5) Notice you cannot click 'Next' until you put something in invoice number. Sponsored-by: Catalyst IT Please add the "validated" class to the <form> so that the validation plugin can pick up the required fields. I realize it's not strictly necessary because of the browser's built-in handling of required fields, but I think it makes the user's experience more consistent. Created attachment 50772 [details] [review] Bug 16351: Making invoice number a required field EDIT: Added 'validated' class to form and removed 'Required' span (became unnecessary) To test: 1) Go to Acqui -> Do a vendor search 2) Receive a shipment 3) Attempt to click 'Next' without specifying invoice number. Notice error. 4) Go back to vendor search then apply patch. Click Receive shipment 5) Notice you cannot click 'Next' until you put something in invoice number. Sponsored-by: Catalyst IT Created attachment 50816 [details] [review] Bug 16351: Making invoice number a required field EDIT: Added 'validated' class to form and removed 'Required' span (became unnecessary) To test: 1) Go to Acqui -> Do a vendor search 2) Receive a shipment 3) Attempt to click 'Next' without specifying invoice number. Notice error. 4) Go back to vendor search then apply patch. Click Receive shipment 5) Notice you cannot click 'Next' until you put something in invoice number. Sponsored-by: Catalyst IT Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 50836 [details] [review] [PASSED QA] Bug 16351: Making invoice number a required field EDIT: Added 'validated' class to form and removed 'Required' span (became unnecessary) To test: 1) Go to Acqui -> Do a vendor search 2) Receive a shipment 3) Attempt to click 'Next' without specifying invoice number. Notice error. 4) Go back to vendor search then apply patch. Click Receive shipment 5) Notice you cannot click 'Next' until you put something in invoice number. Sponsored-by: Catalyst IT Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Note: Error is only shown when AcqWarnOnDuplicateInvoice is not in use. Pushed to master, should be in the May 2016 release! Thanks Aleisha! |