Bug 16351 - Error when trying to receive a new shipment without specifying invoice number
Summary: Error when trying to receive a new shipment without specifying invoice number
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Aleisha Amohia
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-26 01:27 UTC by Aleisha Amohia
Modified: 2016-12-05 21:27 UTC (History)
3 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16351: Making invoice number a required field (1.60 KB, patch)
2016-04-26 01:29 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 16351: Making invoice number a required field (1.80 KB, patch)
2016-04-27 00:32 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 16351: Making invoice number a required field (1.93 KB, patch)
2016-04-27 15:00 UTC, Marc Véron
Details | Diff | Splinter Review
[PASSED QA] Bug 16351: Making invoice number a required field (2.00 KB, patch)
2016-04-27 16:56 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2016-04-26 01:27:09 UTC
Triggers an error if you don't specify an invoice number. This could be avoided by making invoice number a required field.
Comment 1 Aleisha Amohia 2016-04-26 01:29:28 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2016-04-26 16:43:53 UTC
Please add the "validated" class to the <form> so that the validation plugin can pick up the required fields. I realize it's not strictly necessary because of the browser's built-in handling of required fields, but I think it makes the user's experience more consistent.
Comment 3 Aleisha Amohia 2016-04-27 00:32:26 UTC Comment hidden (obsolete)
Comment 4 Marc Véron 2016-04-27 15:00:15 UTC Comment hidden (obsolete)
Comment 5 Katrin Fischer 2016-04-27 16:56:22 UTC
Created attachment 50836 [details] [review]
[PASSED QA] Bug 16351: Making invoice number a required field

EDIT: Added 'validated' class to form and removed 'Required' span (became unnecessary)

To test:
1) Go to Acqui -> Do a vendor search
2) Receive a shipment
3) Attempt to click 'Next' without specifying invoice number. Notice error.
4) Go back to vendor search then apply patch. Click Receive shipment
5) Notice you cannot click 'Next' until you put something in invoice number.

Sponsored-by: Catalyst IT

Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Katrin Fischer 2016-04-27 16:57:55 UTC
Note: Error is only shown when AcqWarnOnDuplicateInvoice is not in use.
Comment 7 Kyle M Hall 2016-04-29 10:45:19 UTC
Pushed to master, should be in the May 2016 release! Thanks Aleisha!