Summary: | Untranslatable strings in grouped OPAC results | ||
---|---|---|---|
Product: | Koha | Reporter: | paxed <pasi.kallinen> |
Component: | I18N/L10N | Assignee: | paxed <pasi.kallinen> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | f.demians, fridolin.somers, katrin.fischer, martin.renvoize, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20410 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 20332: Allow translating some grouped opac results texts
Bug 20332: Allow translating some grouped opac results texts Bug 20332: Allow translating some grouped opac results texts |
Description
paxed
2018-03-05 10:40:27 UTC
Created attachment 72414 [details] [review] Bug 20332: Allow translating some grouped opac results texts The grouped OPAC results page has several untranslatable javascript-added texts, including the selection modifiers "Clear all" and "Select all" links, and the entries in the shelves/lists dropdown. No test plan, as I can't test it - we don't use the grouped results, and I don't have pazpar2 installed. I think PazPar2 and grouped results are going to be deprecated, see bug 20410. But changes make sense from carefully reading and checking them. I am going to sign-off. Created attachment 76758 [details] [review] Bug 20332: Allow translating some grouped opac results texts The grouped OPAC results page has several untranslatable javascript-added texts, including the selection modifiers "Clear all" and "Select all" links, and the entries in the shelves/lists dropdown. Compare to opac-results.tt Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 76860 [details] [review] Bug 20332: Allow translating some grouped opac results texts The grouped OPAC results page has several untranslatable javascript-added texts, including the selection modifiers "Clear all" and "Select all" links, and the entries in the shelves/lists dropdown. Compare to opac-results.tt Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Awesome work all! Pushed to master for 18.11 Pushed to 18.05.x for 18.05.02 Pushed to 17.11.x for 17.11.09 |