This is used only once according to HEA, but i am pretty sure this doesn't work, and probably never will. I suggest removing it entirely.
Quick note: The pref is not in sysprefs.sql Use `git grep -i OpacGroupResults` to know where this pref is used.
Also remove PazPar2 related files ?
If the feature is tied to them it would be the consequence I think. I feel like we should bring up these kind of decisions on the mailing lists and then to a vote at the meeting.
Asked for deprecation on the list - https://lists.katipo.co.nz/pipermail/koha/2020-November/055362.html
Created attachment 116220 [details] [review] Bug 20410: Remove OpacGroupResults and PazPar2 This feature is not used as far as we know and it's not known to work. It's preferable to remove it. Test plan: Make sure the OpacGroupResults pref code is removed, as well as the PazPar2 files and code.
Created attachment 116248 [details] [review] Bug 20410: Remove OpacGroupResults and PazPar2 This feature is not used as far as we know and it's not known to work. It's preferable to remove it. Test plan: Make sure the OpacGroupResults pref code is removed, as well as the PazPar2 files and code. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 116478 [details] [review] Bug 20410: Remove OpacGroupResults and PazPar2 This feature is not used as far as we know and it's not known to work. It's preferable to remove it. Test plan: Make sure the OpacGroupResults pref code is removed, as well as the PazPar2 files and code. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 21.05, thanks to everybody involved!
Enhancement not pushed to 20.11.x I prefer not remove a feature in stable branch.