Bug 20516

Summary: Show patron's library in pending discharges table
Product: Koha Reporter: Julian Maurice <julian.maurice>
Component: PatronsAssignee: Julian Maurice <julian.maurice>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: axelle.clarisse, gmcharlt, katrin.fischer, kyle.m.hall, martin.renvoize
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20524
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 20526    
Attachments: Bug 20516: Show patron's library in pending discharges table
Bug 20516: Show patron's library in pending discharges table
Bug 20516: Show patron's library in pending discharges table

Description Julian Maurice 2018-04-04 12:08:03 UTC

    
Comment 1 Julian Maurice 2018-04-04 12:15:24 UTC
Created attachment 73616 [details] [review]
Bug 20516: Show patron's library in pending discharges table

Test plan:
1. Enable syspref useDischarge
2. Login to OPAC and ask for a discharge (tab on the left)
3. Login to intranet, you should see a message about pending discharges,
   and a link. Click on the link.
4. Confirm that there is a 'Library' column in the table that is
   displaying the patron's library
Comment 2 Mark Tompsett 2018-04-04 15:00:14 UTC
Created attachment 73644 [details] [review]
Bug 20516: Show patron's library in pending discharges table

Test plan:
1. Enable syspref useDischarge
2. Login to OPAC and ask for a discharge (tab on the left)
3. Login to intranet, you should see a message about pending discharges,
   and a link. Click on the link.
4. Confirm that there is a 'Library' column in the table that is
   displaying the patron's library

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Comment 3 Katrin Fischer 2018-04-05 05:49:13 UTC
Created attachment 73672 [details] [review]
Bug 20516: Show patron's library in pending discharges table

Test plan:
1. Enable syspref useDischarge
2. Login to OPAC and ask for a discharge (tab on the left)
3. Login to intranet, you should see a message about pending discharges,
   and a link. Click on the link.
4. Confirm that there is a 'Library' column in the table that is
   displaying the patron's library

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Katrin Fischer 2018-04-05 05:49:47 UTC
Is there a good rule about when it's better to use the class methods and when to use the TT plugin?
Comment 5 Julian Maurice 2018-04-05 07:42:16 UTC
(In reply to Katrin Fischer from comment #4)
> Is there a good rule about when it's better to use the class methods and
> when to use the TT plugin?

I suppose the TT plugin is only useful when all you have is a branchcode (not an object).
Comment 6 Jonathan Druart 2018-04-05 17:55:05 UTC
Pushed to master for 18.05, thanks to everybody involved!