Bug 20524 - Make columns of pending discharges table sortable
Summary: Make columns of pending discharges table sortable
Status: Pushed to Master
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Julian Maurice
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 20526
  Show dependency treegraph
 
Reported: 2018-04-05 11:24 UTC by Julian Maurice
Modified: 2018-04-06 17:53 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 20524: Make columns of pending discharges table sortable (2.13 KB, patch)
2018-04-05 11:25 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 20524: Make columns of pending discharges table sortable (2.19 KB, patch)
2018-04-05 13:22 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 20524: Make columns of pending discharges table sortable (2.24 KB, patch)
2018-04-06 05:43 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Maurice 2018-04-05 11:24:08 UTC

    
Comment 1 Julian Maurice 2018-04-05 11:25:05 UTC
Created attachment 73680 [details] [review]
Bug 20524: Make columns of pending discharges table sortable

Test plan:
1. Enable syspref useDischarge
2. Login to OPAC and ask for a discharge (tab on the left)
3. Login to OPAC with another borrower from another library and ask for
   a discharge
4. Login to intranet, you should see a message about pending discharges,
   and a link. Click on the link.
5. Confirm that the Patron column is sortable and the Allow column is
   not
6. (Optional) You can apply bug 20516 and confirm that the Library
   column is sortable too
Comment 2 Julian Maurice 2018-04-05 13:22:24 UTC
Created attachment 73686 [details] [review]
Bug 20524: Make columns of pending discharges table sortable

Test plan:
1. Enable syspref useDischarge
2. Login to OPAC and ask for a discharge (tab on the left)
3. Login to OPAC with another borrower from another library and ask for
   a discharge
4. Login to intranet, you should see a message about pending discharges,
   and a link. Click on the link.
5. Confirm that the Patron column is sortable and the Allow column is
   not
6. (Optional) You can apply bug 20516 and confirm that the Library
   column is sortable too

Signed-off-by: Axelle Clarisse <axelle.clarisse@univ-amu.fr>
Comment 3 Katrin Fischer 2018-04-06 05:43:42 UTC
Created attachment 73727 [details] [review]
Bug 20524: Make columns of pending discharges table sortable

Test plan:
1. Enable syspref useDischarge
2. Login to OPAC and ask for a discharge (tab on the left)
3. Login to OPAC with another borrower from another library and ask for
   a discharge
4. Login to intranet, you should see a message about pending discharges,
   and a link. Click on the link.
5. Confirm that the Patron column is sortable and the Allow column is
   not
6. (Optional) You can apply bug 20516 and confirm that the Library
   column is sortable too

Signed-off-by: Axelle Clarisse <axelle.clarisse@univ-amu.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Jonathan Druart 2018-04-06 17:53:49 UTC
Pushed to master for 18.05, thanks to everybody involved!