Bug 20761

Summary: Advanced Cataloging Editor - Rancor - Some js files are not fetched using Asset
Product: Koha Reporter: Nick Clemens (kidclamp) <nick>
Component: CatalogingAssignee: Nick Clemens (kidclamp) <nick>
Status: CLOSED FIXED QA Contact: Chris Cormack <chris>
Severity: major    
Priority: P5 - low CC: fridolin.somers, jonathan.druart, josef.moravec, katrin.fischer, m.de.rooy, martin.renvoize
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 20538    
Bug Blocks:    
Attachments: Bug 20761: Fix some js includes in rancor
Bug 20761: Fix some js includes in rancor
Bug 20761: Fix some js includes in rancor

Description Nick Clemens (kidclamp) 2018-05-13 01:44:18 UTC
To recreate:
1 - Load the advanced cataloging editor
2 - Inspect the network tab in your browser (F12)
3 - Note failure to load 'cataloging_.js'
4 - Note some other scripts don't have versioning
Comment 1 Nick Clemens (kidclamp) 2018-05-13 01:46:06 UTC
Created attachment 75292 [details] [review]
Bug 20761: Fix some js includes in rancor

To test:
1 - Load the advanced cataloging editor
2 - Inspect the network tab in your browser (F12)
3 - Note failure to load 'cataloging_.js'
4 - Note some other scripts don't have versioning
5 - Apply patch
6 - Reload page
7 - Note cataloging.js loads with version number
8 - Note more js files have versioning
Comment 2 Katrin Fischer 2018-05-28 21:18:12 UTC
Created attachment 75613 [details] [review]
Bug 20761: Fix some js includes in rancor

To test:
1 - Load the advanced cataloging editor
2 - Inspect the network tab in your browser (F12)
3 - Note failure to load 'cataloging_.js'
4 - Note some other scripts don't have versioning
5 - Apply patch
6 - Reload page
7 - Note cataloging.js loads with version number
8 - Note more js files have versioning

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 3 Jonathan Druart 2018-05-28 21:57:02 UTC
That's odd, how did we miss these ones??
Comment 4 Chris Cormack 2018-05-29 08:22:06 UTC
Created attachment 75619 [details] [review]
Bug 20761: Fix some js includes in rancor

To test:
1 - Load the advanced cataloging editor
2 - Inspect the network tab in your browser (F12)
3 - Note failure to load 'cataloging_.js'
4 - Note some other scripts don't have versioning
5 - Apply patch
6 - Reload page
7 - Note cataloging.js loads with version number
8 - Note more js files have versioning

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Comment 5 Nick Clemens (kidclamp) 2018-05-29 14:44:04 UTC
Pushed to master for 18.11.

Awesome work all, thank you.
Comment 6 Martin Renvoize 2018-06-05 10:47:32 UTC
This patch has been pushed to 18.05.x and will be in 18.05.01
Comment 7 Fridolin Somers 2018-06-07 07:04:12 UTC
Depends on Bug 20538 not in 17.11.x