To recreate: 1 - Load the advanced cataloging editor 2 - Inspect the network tab in your browser (F12) 3 - Note failure to load 'cataloging_.js' 4 - Note some other scripts don't have versioning
Created attachment 75292 [details] [review] Bug 20761: Fix some js includes in rancor To test: 1 - Load the advanced cataloging editor 2 - Inspect the network tab in your browser (F12) 3 - Note failure to load 'cataloging_.js' 4 - Note some other scripts don't have versioning 5 - Apply patch 6 - Reload page 7 - Note cataloging.js loads with version number 8 - Note more js files have versioning
Created attachment 75613 [details] [review] Bug 20761: Fix some js includes in rancor To test: 1 - Load the advanced cataloging editor 2 - Inspect the network tab in your browser (F12) 3 - Note failure to load 'cataloging_.js' 4 - Note some other scripts don't have versioning 5 - Apply patch 6 - Reload page 7 - Note cataloging.js loads with version number 8 - Note more js files have versioning Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
That's odd, how did we miss these ones??
Created attachment 75619 [details] [review] Bug 20761: Fix some js includes in rancor To test: 1 - Load the advanced cataloging editor 2 - Inspect the network tab in your browser (F12) 3 - Note failure to load 'cataloging_.js' 4 - Note some other scripts don't have versioning 5 - Apply patch 6 - Reload page 7 - Note cataloging.js loads with version number 8 - Note more js files have versioning Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Pushed to master for 18.11. Awesome work all, thank you.
This patch has been pushed to 18.05.x and will be in 18.05.01
Depends on Bug 20538 not in 17.11.x