Bug 21132

Summary: Highlight active filters on saved report page
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: martin.renvoize, nick
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Screenshot showing the search term highlighting
Bug 21132: Highlight active filters on saved report page
Bug 21132: Highlight active filters on saved report page
Bug 21132: Highlight active filters on saved report page

Description Owen Leonard 2018-07-30 17:32:52 UTC
Created attachment 77325 [details]
Screenshot showing the search term highlighting

I propose to add a more obvious view of which terms have been submitted to filter the saved reports page.
Comment 1 Owen Leonard 2018-07-30 17:39:31 UTC
Created attachment 77326 [details] [review]
Bug 21132: Highlight active filters on saved report page

This patch adds a more obvious way of see which search terms have been
submitted to filter the table of saved reports.

The patch also moves embedded CSS into a separate file.

To test you should have multiple saved reports.

- Apply the patch and go to Reports -> Use saved.
- Filter the table of reports by submitting one or more terms in the
  sidebar "Filter" form.
- Confirm that the terms you submit are shown at the top of the table of
  results.
- Confirm that clicking the "Clear" link clears the search filter.
Comment 2 Maryse Simard 2018-08-03 18:19:18 UTC
Created attachment 77482 [details] [review]
Bug 21132: Highlight active filters on saved report page

This patch adds a more obvious way of see which search terms have been
submitted to filter the table of saved reports.

The patch also moves embedded CSS into a separate file.

To test you should have multiple saved reports.

- Apply the patch and go to Reports -> Use saved.
- Filter the table of reports by submitting one or more terms in the
  sidebar "Filter" form.
- Confirm that the terms you submit are shown at the top of the table of
  results.
- Confirm that clicking the "Clear" link clears the search filter.

Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Followed the test plan and it works.
Comment 3 Jonathan Druart 2018-08-06 17:25:43 UTC
Created attachment 77495 [details] [review]
Bug 21132: Highlight active filters on saved report page

This patch adds a more obvious way of see which search terms have been
submitted to filter the table of saved reports.

The patch also moves embedded CSS into a separate file.

To test you should have multiple saved reports.

- Apply the patch and go to Reports -> Use saved.
- Filter the table of reports by submitting one or more terms in the
  sidebar "Filter" form.
- Confirm that the terms you submit are shown at the top of the table of
  results.
- Confirm that clicking the "Clear" link clears the search filter.

Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Followed the test plan and it works.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Nick Clemens 2018-08-09 12:38:00 UTC
Awesome work all!

Pushed to master for 18.11
Comment 5 Martin Renvoize 2018-08-10 08:16:49 UTC
Enhancement, will not backport to 18.05.x series.